Update jetty:9-jre* images to Jetty 9.2.8 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Dillon <mike@embody.org>
|
BTW, those "general bug fixes" include some patches I made to make |
|
LGTM. Build test of #501; c516288 ( $ url="https://raw.githubusercontent.com/docker-library/official-images/c516288eebfbe4171a80f94ca29932532991eb80/library/jetty"
$ bashbrew build "$url"
Fetching jetty (git://github.com/md5/docker-jetty) ...
Processing jetty:7.6.16-jre7 ...
Processing jetty:7.6-jre7 ...
Processing jetty:7-jre7 ...
Processing jetty:7.6.16 ...
Processing jetty:7.6 ...
Processing jetty:7 ...
Processing jetty:7.6.16-jre8 ...
Processing jetty:7.6-jre8 ...
Processing jetty:7-jre8 ...
Processing jetty:8.1.16-jre7 ...
Processing jetty:8.1-jre7 ...
Processing jetty:8-jre7 ...
Processing jetty:8.1.16 ...
Processing jetty:8.1 ...
Processing jetty:8 ...
Processing jetty:8.1.16-jre8 ...
Processing jetty:8.1-jre8 ...
Processing jetty:8-jre8 ...
Processing jetty:9.2.8-jre7 ...
Processing jetty:9.2-jre7 ...
Processing jetty:9-jre7 ...
Processing jetty:jre7 ...
Processing jetty:9.2.8 ...
Processing jetty:9.2 ...
Processing jetty:9 ...
Processing jetty:latest ...
Processing jetty:9.2.8-jre8 ...
Processing jetty:9.2-jre8 ...
Processing jetty:9-jre8 ...
Processing jetty:jre8 ...
$ bashbrew list "$url" | xargs test/run.sh
testing jetty:7.6.16-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7.6-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7.6.16
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7.6
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7.6.16-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7.6-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:7-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8.1.16-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8.1-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8.1.16
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8.1
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8.1.16-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8.1-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:8-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9.2.8-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9.2-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9-jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:jre7
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9.2.8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9.2
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:latest
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9.2.8-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9.2-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:9-jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed
testing jetty:jre8
'utc' [1/2]...passed
'cve-2014--shellshock' [2/2]...passed |
|
The That actually explains (for me) why 7 and 8 are showing updates without showing any changed files; there were intervening changed that added code to remove |
|
LGTM! |
tianon
added a commit
that referenced
this pull request
Feb 20, 2015
Update jetty:9-jre* images to Jetty 9.2.8
|
Thanks! I'll send through a separate PR tomorrow to complete the EOL for Jetty 7 and 8. |
|
👍!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
jetty-announce:I'm not sure why the 7 and 8 images are showing up in this diff, but there's nothing wrong with the new shas either (cf. appropriate/docker-jetty@74bdfc4...394a77a).
Also, may I get your opinion on whether I should include the changes needed to address appropriate/docker-jetty#2 and remove Jetty 7 and 8? They were apparently EOL'd at the end of 2014.