Add new NUXEOCTL_CONSOLE_OPTIONS parameter

[ffjdm]

No description provided.

[tianon]

cc @dmetzler @akervern

Diff:

diff --git a/nuxeo_10.1/docker-entrypoint.sh b/nuxeo_10.1/docker-entrypoint.sh
index 2fc1b57..0dc404a 100755
--- a/nuxeo_10.1/docker-entrypoint.sh
+++ b/nuxeo_10.1/docker-entrypoint.sh
@@ -69,7 +69,7 @@ EOF
   fi
 
   if [ "$2" = "console" ]; then
-    exec nuxeoctl console
+    exec nuxeoctl console $NUXEOCTL_CONSOLE_OPTIONS
   else
     exec "$@"
   fi
diff --git a/nuxeo_LTS/docker-entrypoint.sh b/nuxeo_LTS/docker-entrypoint.sh
index 2fc1b57..0dc404a 100755
--- a/nuxeo_LTS/docker-entrypoint.sh
+++ b/nuxeo_LTS/docker-entrypoint.sh
@@ -69,7 +69,7 @@ EOF
   fi
 
   if [ "$2" = "console" ]; then
-    exec nuxeoctl console
+    exec nuxeoctl console $NUXEOCTL_CONSOLE_OPTIONS
   else
     exec "$@"
   fi
diff --git a/nuxeo_latest/docker-entrypoint.sh b/nuxeo_latest/docker-entrypoint.sh
index 2fc1b57..0dc404a 100755
--- a/nuxeo_latest/docker-entrypoint.sh
+++ b/nuxeo_latest/docker-entrypoint.sh
@@ -69,7 +69,7 @@ EOF
   fi
 
   if [ "$2" = "console" ]; then
-    exec nuxeoctl console
+    exec nuxeoctl console $NUXEOCTL_CONSOLE_OPTIONS
   else
     exec "$@"
   fi

[tianon]

Can you elaborate on why this was done as an environment variable instead of simply as additional arguments?

For example, the following is how I'd implement this, which would allow for directly doing docker run ... nuxeo nuxeoctl console --ignore-missing, which IMO is way more natural than an environment variable:

  if [ "$2" = "console" ]; then
    exec nuxeoctl console "${@:2}"
  else
    exec "$@"
  fi

That being said though, in this case, isn't $1 already nuxeoctl? So if $2 is then console, why does this special case exist at all? Why isn't this simply handled by exec "$@" which should DTRT already?

[dmetzler]

I agree on your last comment.... I tried to review the history of that code (which I wrote :-) ) but I don't remember the exact reason for that.

We will modify accordingly, thx for the review.

[tianon]

Why not? Compose supports "command:" for editing the container command.

[ffjdm]

Indeed but the image has to be cleaned up first. Please see #4776 for this.