Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a jessie flavour for erlang/otp 21 #4600

Merged

Conversation

c0b
Copy link
Contributor

@c0b c0b commented Jul 17, 2018

there are still many users on jessie
erlang/docker-erlang-otp#131 (comment)

library/erlang Outdated
@@ -18,6 +18,11 @@ Architectures: amd64, arm64v8, i386, s390x, ppc64le
GitCommit: f0fffe2ba666a5f31e1de81d80dacdbf405c8e32
Directory: 21/alpine

Tags: 21.0.3-jessie, 21.0-jessie, 21-jessie, jessie
Architectures: amd64, arm32v7, arm64v8, i386, s390x, ppc64le
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debian Jessie is no longer supported on all these architectures since it has transitioned to the Debian LTS team:

Tags: jessie, jessie-20180716, 8.11, 8
Architectures: amd64, arm32v5, arm32v7, i386

See also https://wiki.debian.org/LTS

@c0b c0b force-pushed the feature/erlang-otp-21-jessie-flavor branch from aa293a9 to 199719d Compare July 17, 2018 23:28
@c0b
Copy link
Contributor Author

c0b commented Jul 17, 2018

@yosifkit how about now?

@yosifkit
Copy link
Member

Diff:
diff --git a/_bashbrew-arches b/_bashbrew-arches
index f0b161d..02dfaab 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -52,6 +52,9 @@ erlang:alpine @ arm64v8
 erlang:alpine @ i386
 erlang:alpine @ ppc64le
 erlang:alpine @ s390x
+erlang:jessie @ amd64
+erlang:jessie @ arm32v7
+erlang:jessie @ i386
 erlang:latest @ amd64
 erlang:latest @ arm32v7
 erlang:latest @ arm64v8
diff --git a/_bashbrew-list b/_bashbrew-list
index 03d7c07..5638ff3 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -36,13 +36,17 @@ erlang:20.3.8.2-alpine
 erlang:20.3.8.2-slim
 erlang:21
 erlang:21-alpine
+erlang:21-jessie
 erlang:21-slim
 erlang:21.0
 erlang:21.0-alpine
+erlang:21.0-jessie
 erlang:21.0-slim
 erlang:21.0.3
 erlang:21.0.3-alpine
+erlang:21.0.3-jessie
 erlang:21.0.3-slim
 erlang:alpine
+erlang:jessie
 erlang:latest
 erlang:slim
diff --git a/erlang_latest/Dockerfile b/erlang_jessie/Dockerfile
similarity index 98%
copy from erlang_latest/Dockerfile
copy to erlang_jessie/Dockerfile
index 9bef17d..078d162 100644
--- a/erlang_latest/Dockerfile
+++ b/erlang_jessie/Dockerfile
@@ -1,4 +1,4 @@
-FROM buildpack-deps:stretch
+FROM buildpack-deps:jessie
 
 ENV OTP_VERSION="21.0.3"
 

@yosifkit
Copy link
Member

Build test of #4600; 199719d; amd64 (erlang):

$ bashbrew build erlang:21.0.3
Using bashbrew/cache:d416db6686b1d640569e53ccc7804e6f288d83816366dedcb419be4304c25cc3 (erlang:21.0.3)
Tagging erlang:21.0.3
Tagging erlang:21.0
Tagging erlang:21
Tagging erlang:latest

$ test/run.sh erlang:21.0.3
testing erlang:21.0.3
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:21.0.3-slim
Using bashbrew/cache:420633074ff57fab4a407e12bd26aeb3628a675a624fd0b51f17f14dbd0eef3d (erlang:21.0.3-slim)
Tagging erlang:21.0.3-slim
Tagging erlang:21.0-slim
Tagging erlang:21-slim
Tagging erlang:slim

$ test/run.sh erlang:21.0.3-slim
testing erlang:21.0.3-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:21.0.3-alpine
Using bashbrew/cache:b4acf2ede34373c4c23542f6580d3764559b7fb1477480a49eaef04e275ae7e6 (erlang:21.0.3-alpine)
Tagging erlang:21.0.3-alpine
Tagging erlang:21.0-alpine
Tagging erlang:21-alpine
Tagging erlang:alpine

$ test/run.sh erlang:21.0.3-alpine
testing erlang:21.0.3-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:21.0.3-jessie
Using bashbrew/cache:35678a2eb2823ebc9c423d435e565c4d41084c24ea738940ed91e20fd9aa4e20 (erlang:21.0.3-jessie)
Tagging erlang:21.0.3-jessie
Tagging erlang:21.0-jessie
Tagging erlang:21-jessie
Tagging erlang:jessie

$ test/run.sh erlang:21.0.3-jessie
testing erlang:21.0.3-jessie
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:20.3.8.2
Using bashbrew/cache:a7d8863288258222809f3de75c02214ab3a281ba98360e891b095d8a6cdb3651 (erlang:20.3.8.2)
Tagging erlang:20.3.8.2
Tagging erlang:20.3.8
Tagging erlang:20.3
Tagging erlang:20

$ test/run.sh erlang:20.3.8.2
testing erlang:20.3.8.2
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:20.3.8.2-slim
Using bashbrew/cache:6f1ce97c7326c9f56f9d07e1ef7c9bc334fb24fb34f5935440437ee7da206ef3 (erlang:20.3.8.2-slim)
Tagging erlang:20.3.8.2-slim
Tagging erlang:20.3.8-slim
Tagging erlang:20.3-slim
Tagging erlang:20-slim

$ test/run.sh erlang:20.3.8.2-slim
testing erlang:20.3.8.2-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:20.3.8.2-alpine
Using bashbrew/cache:7bf39625a9c66ece5e8613cc33e97b37cf02a224edb928838fb377e23c46eb3b (erlang:20.3.8.2-alpine)
Tagging erlang:20.3.8.2-alpine
Tagging erlang:20.3.8-alpine
Tagging erlang:20.3-alpine
Tagging erlang:20-alpine

$ test/run.sh erlang:20.3.8.2-alpine
testing erlang:20.3.8.2-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:19.3.6.9
Using bashbrew/cache:b4728c26dca0493ff86236606d69e80dbb1abaa4245190c9f63c961d18aedbc9 (erlang:19.3.6.9)
Tagging erlang:19.3.6.9
Tagging erlang:19.3.6
Tagging erlang:19.3
Tagging erlang:19

$ test/run.sh erlang:19.3.6.9
testing erlang:19.3.6.9
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:19.3.6.9-slim
Using bashbrew/cache:90651be2d335e6bfd894b83505f24d9bdd7b050a10b373f17b40978620798751 (erlang:19.3.6.9-slim)
Tagging erlang:19.3.6.9-slim
Tagging erlang:19.3.6-slim
Tagging erlang:19.3-slim
Tagging erlang:19-slim

$ test/run.sh erlang:19.3.6.9-slim
testing erlang:19.3.6.9-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:18.3.4.9
Using bashbrew/cache:6c997f31f6848f308aa716142fe817b75e8b399f5edf6c9dcf75f0e1fbc65a3b (erlang:18.3.4.9)
Tagging erlang:18.3.4.9
Tagging erlang:18.3.4
Tagging erlang:18.3
Tagging erlang:18

$ test/run.sh erlang:18.3.4.9
testing erlang:18.3.4.9
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:18.3.4.9-slim
Using bashbrew/cache:af6c5cbb2742d629dce7bb373cf322cbfd058fca3a06dba09e8cf0d0e65ff51e (erlang:18.3.4.9-slim)
Tagging erlang:18.3.4.9-slim
Tagging erlang:18.3.4-slim
Tagging erlang:18.3-slim
Tagging erlang:18-slim

$ test/run.sh erlang:18.3.4.9-slim
testing erlang:18.3.4.9-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:17.5.6.9
Using bashbrew/cache:96513b27506e78e9882fe0637010be36d8e401255b789e2752ae6d2a886a6d82 (erlang:17.5.6.9)
Tagging erlang:17.5.6.9
Tagging erlang:17.5.6
Tagging erlang:17.5
Tagging erlang:17

$ test/run.sh erlang:17.5.6.9
testing erlang:17.5.6.9
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed


$ bashbrew build erlang:17.5.6.9-slim
Using bashbrew/cache:8e475eafc4423de7a2856702d58a9c754db22bdbb90502a768af05cf8bbb395a (erlang:17.5.6.9-slim)
Tagging erlang:17.5.6.9-slim
Tagging erlang:17.5.6-slim
Tagging erlang:17.5-slim
Tagging erlang:17-slim

$ test/run.sh erlang:17.5.6.9-slim
testing erlang:17.5.6.9-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'erlang-hello-world' [5/5]...passed

@yosifkit yosifkit merged commit dcba7c1 into docker-library:master Jul 18, 2018
@c0b c0b deleted the feature/erlang-otp-21-jessie-flavor branch October 30, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants