-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ARM64v8 support in Kaazing Gateway #4575
Enable ARM64v8 support in Kaazing Gateway #4575
Conversation
9684120
to
9abbcaf
Compare
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Solves Travis complaint: 'RFC 2822 error: missing Maintainers' Signed-off-by: Lee Jones <lee.jones@linaro.org>
ab5e8b5
to
5fc56cc
Compare
…Travis build Solves Travis complaint: 'RFC 2822 error: Tags "" has invalid GitCommit (must be a commit, not a tag or ref): ""' Signed-off-by: Lee Jones <lee.jones@linaro.org>
Instead of using only '5.6.0', also provide '5.6' and '5' options as suggested in: https://github.com/docker-library/official-images#tags-and-aliases Signed-off-by: Lee Jones <lee.jones@linaro.org>
5fc56cc
to
ce15e29
Compare
LGTM |
Thanks @dpwspoon ❤️ Diff:diff --git a/_bashbrew-arches b/_bashbrew-arches
index 63ba10b..624b60b 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -1 +1,2 @@
-kaazing-gateway:5.6.0 @ amd64
+kaazing-gateway:latest @ amd64
+kaazing-gateway:latest @ arm64v8
diff --git a/_bashbrew-list b/_bashbrew-list
index f53dd9c..5dc7f56 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,2 +1,4 @@
+kaazing-gateway:5
+kaazing-gateway:5.6
kaazing-gateway:5.6.0
kaazing-gateway:latest
diff --git a/kaazing-gateway_5.6.0/Dockerfile b/kaazing-gateway_latest/Dockerfile
similarity index 100%
rename from kaazing-gateway_5.6.0/Dockerfile
rename to kaazing-gateway_latest/Dockerfile |
LGTM Build test of #4575; ce15e29; $ bashbrew build kaazing-gateway:5.6.0
Building bashbrew/cache:698ae84f6c3479bb44aff62952a6127602c39cfa49b473daa22282a39bd05494 (kaazing-gateway:5.6.0)
Tagging kaazing-gateway:5.6.0
Tagging kaazing-gateway:5.6
Tagging kaazing-gateway:5
Tagging kaazing-gateway:latest
$ test/run.sh kaazing-gateway:5.6.0
testing kaazing-gateway:5.6.0
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...passed
|
Friendly ping @dpwspoon -- is this image still relevant? Is Kaazing Gateway still maintained? |
Yes it is, @tianon. |
@robinzimmermann that's good to hear! The reason I'm asking is because https://github.com/kaazing/gateway doesn't appear to have been touched since Feb 2018 and the Dockerfile repo is even older (2017). I imagine the image is likely due for an update of some kind, even if just to make sure the base image is still supported? ( Even this PR wasn't really an image source update (as seen by the unchanged commit). |
Friendly ping -- the |
We're just shy of 700 days since this update to the |
Cc: Kazzing Maintainers (@kaazing)
Cc: David Witherspoon (@dpwspoon)
Signed-off-by: Lee Jones lee.jones@linaro.org