Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ARM64v8 support in Kaazing Gateway #4575

Merged

Conversation

lag-linaro
Copy link
Contributor

Cc: Kazzing Maintainers (@kaazing)
Cc: David Witherspoon (@dpwspoon)
Signed-off-by: Lee Jones lee.jones@linaro.org

Lee Jones added 2 commits July 12, 2018 09:17
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Solves Travis complaint:

  'RFC 2822 error: missing Maintainers'

Signed-off-by: Lee Jones <lee.jones@linaro.org>
@lag-linaro lag-linaro force-pushed the kaazing-gateway-enable-arm64v8 branch from ab5e8b5 to 5fc56cc Compare July 12, 2018 08:18
Lee Jones added 2 commits July 12, 2018 09:25
…Travis build

Solves Travis complaint:

  'RFC 2822 error: Tags "" has invalid GitCommit (must be a commit, not a tag or ref): ""'

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Instead of using only '5.6.0', also provide '5.6' and '5' options as
suggested in:

  https://github.com/docker-library/official-images#tags-and-aliases

Signed-off-by: Lee Jones <lee.jones@linaro.org>
@lag-linaro lag-linaro force-pushed the kaazing-gateway-enable-arm64v8 branch from 5fc56cc to ce15e29 Compare July 12, 2018 08:26
@dpwspoon
Copy link
Contributor

LGTM

@tianon
Copy link
Member

tianon commented Jul 12, 2018

Thanks @dpwspoon ❤️

Diff:
diff --git a/_bashbrew-arches b/_bashbrew-arches
index 63ba10b..624b60b 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -1 +1,2 @@
-kaazing-gateway:5.6.0 @ amd64
+kaazing-gateway:latest @ amd64
+kaazing-gateway:latest @ arm64v8
diff --git a/_bashbrew-list b/_bashbrew-list
index f53dd9c..5dc7f56 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,2 +1,4 @@
+kaazing-gateway:5
+kaazing-gateway:5.6
 kaazing-gateway:5.6.0
 kaazing-gateway:latest
diff --git a/kaazing-gateway_5.6.0/Dockerfile b/kaazing-gateway_latest/Dockerfile
similarity index 100%
rename from kaazing-gateway_5.6.0/Dockerfile
rename to kaazing-gateway_latest/Dockerfile

@tianon
Copy link
Member

tianon commented Jul 12, 2018

LGTM

Build test of #4575; ce15e29; amd64 (kaazing-gateway):

$ bashbrew build kaazing-gateway:5.6.0
Building bashbrew/cache:698ae84f6c3479bb44aff62952a6127602c39cfa49b473daa22282a39bd05494 (kaazing-gateway:5.6.0)
Tagging kaazing-gateway:5.6.0
Tagging kaazing-gateway:5.6
Tagging kaazing-gateway:5
Tagging kaazing-gateway:latest

$ test/run.sh kaazing-gateway:5.6.0
testing kaazing-gateway:5.6.0
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed

@tianon tianon merged commit 689a3b0 into docker-library:master Jul 12, 2018
@tianon
Copy link
Member

tianon commented Jun 19, 2019

Friendly ping @dpwspoon -- is this image still relevant? Is Kaazing Gateway still maintained?

@robinzimmermann
Copy link

Yes it is, @tianon.

@tianon
Copy link
Member

tianon commented Jun 27, 2019

@robinzimmermann that's good to hear! The reason I'm asking is because https://github.com/kaazing/gateway doesn't appear to have been touched since Feb 2018 and the Dockerfile repo is even older (2017). I imagine the image is likely due for an update of some kind, even if just to make sure the base image is still supported? (openjdk:8-jre had a fair amount of recent change that affects architecture support, etc)

Even this PR wasn't really an image source update (as seen by the unchanged commit).

@tianon
Copy link
Member

tianon commented Dec 12, 2019

Friendly ping -- the kaazing-gateway image has now been over 500 days without an update of any kind and we're likely going to start considering adding a generic "unmaintained" deprecation notice soon. Any chance an update to this image is on the radar?

@tianon
Copy link
Member

tianon commented May 15, 2020

We're just shy of 700 days since this update to the kaazing-gateway official image (and even longer since the last substantive update to it). Should we start drafting some deprecation text for the image description to more clearly communicate the current status of the image to users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants