Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update influxdata images #4193

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Conversation

jsternberg
Copy link
Contributor

No description provided.

@yosifkit
Copy link
Member

yosifkit commented Apr 2, 2018

Diff:
warning: insecure protocol git:// detected: git://github.com/influxdata/influxdata-docker
diff --git a/_bashbrew-list b/_bashbrew-list
index aeeba81..4390742 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -6,9 +6,9 @@ chronograf:1.3.10.0
 chronograf:1.3.10.0-alpine
 chronograf:1.4
 chronograf:1.4-alpine
-chronograf:1.4.2
-chronograf:1.4.2-alpine
-chronograf:1.4.2.3
-chronograf:1.4.2.3-alpine
+chronograf:1.4.3
+chronograf:1.4.3-alpine
+chronograf:1.4.3.0
+chronograf:1.4.3.0-alpine
 chronograf:alpine
 chronograf:latest
diff --git a/chronograf_alpine/Dockerfile b/chronograf_alpine/Dockerfile
index 5709580..ce5d6bb 100644
--- a/chronograf_alpine/Dockerfile
+++ b/chronograf_alpine/Dockerfile
@@ -4,7 +4,7 @@ RUN echo 'hosts: files dns' >> /etc/nsswitch.conf
 RUN apk add --no-cache ca-certificates && \
     update-ca-certificates
 
-ENV CHRONOGRAF_VERSION 1.4.2.3
+ENV CHRONOGRAF_VERSION 1.4.3.0
 
 RUN set -ex && \
     apk add --no-cache --virtual .build-deps wget gnupg tar && \
diff --git a/chronograf_latest/Dockerfile b/chronograf_latest/Dockerfile
index 6672bf7..47ef1e2 100644
--- a/chronograf_latest/Dockerfile
+++ b/chronograf_latest/Dockerfile
@@ -11,7 +11,7 @@ RUN set -ex && \
         gpg --keyserver keyserver.pgp.com --recv-keys "$key" ; \
     done
 
-ENV CHRONOGRAF_VERSION 1.4.2.3
+ENV CHRONOGRAF_VERSION 1.4.3.0
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" && \
     case "${dpkgArch##*-}" in \
       amd64) ARCH='amd64';; \

@yosifkit
Copy link
Member

yosifkit commented Apr 2, 2018

Build test of #4193; 2a01068; amd64 (chronograf):

$ bashbrew build chronograf:1.3
Building bashbrew/cache:98ea1057ca5e8bdd2d01fb9f2bac4ed607ecaad706bac8b44f652b4c01a5bf2b (chronograf:1.3)
Tagging chronograf:1.3
Tagging chronograf:1.3.10
Tagging chronograf:1.3.10.0

$ test/run.sh chronograf:1.3
testing chronograf:1.3
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build chronograf:1.3-alpine
Building bashbrew/cache:2aa0096de30b7d22e3b5b6ebba51ad309b780a9283f84b3ae63c07e49750b740 (chronograf:1.3-alpine)
Tagging chronograf:1.3-alpine
Tagging chronograf:1.3.10-alpine
Tagging chronograf:1.3.10.0-alpine

$ test/run.sh chronograf:1.3-alpine
testing chronograf:1.3-alpine
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build chronograf:1.4
Building bashbrew/cache:2d40de5156289ced28e76e31cc17ee6e2b61a3efba18dd8ca30c4d5067c9a661 (chronograf:1.4)
Tagging chronograf:1.4
Tagging chronograf:1.4.3
Tagging chronograf:1.4.3.0
Tagging chronograf:latest

$ test/run.sh chronograf:1.4
testing chronograf:1.4
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build chronograf:1.4-alpine
Building bashbrew/cache:f869506c819d55b6982845dbc37bc76e60c76a650e811eb8bf97202580ef33e6 (chronograf:1.4-alpine)
Tagging chronograf:1.4-alpine
Tagging chronograf:1.4.3-alpine
Tagging chronograf:1.4.3.0-alpine
Tagging chronograf:alpine

$ test/run.sh chronograf:1.4-alpine
testing chronograf:1.4-alpine
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed

@yosifkit yosifkit merged commit bd8ed9f into docker-library:master Apr 2, 2018
@jsternberg
Copy link
Contributor Author

I'm not sure if I'm doing something wrong, but it seems like the version attached to the latest and 1.4.3 tag is incorrect. If I do this:

$ docker pull chronograf:1.4.3
$ docker inspect chronograf:1.4.3

I see CHRONOGRAF_VERSION=1.4.2.3. Did something go wrong?

@yosifkit
Copy link
Member

yosifkit commented Apr 2, 2018

That is an artifact of how the manifest lists are created. First, images are built and pushed to their respective architecture namespaces. Then, a periodic job that creates the manifest runs and uses the first tag in the list (1.4 in chrongraf) to determine what to use from each architecture (amd64/chronograf:1.4, arm32v7/chronograf:1.4, etc). Then it pushes a manifest to the library namespace (chronograf) pointing to those images for all tags in the line (1.4, 1.4.3, 1.4.3.0, latest).

This just means that the real 1.4.3 has not been built yet (and thus overridden the old 1.4 tag in amd64/). The tags will fix themselves once the images finish building.

Chronograf is still in the build queue: https://doi-janky.infosiftr.net/job/multiarch/job/amd64/job/chronograf/54/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants