Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nats] Release v1.0.6 #4068

Merged
merged 1 commit into from
Mar 1, 2018
Merged

[nats] Release v1.0.6 #4068

merged 1 commit into from
Mar 1, 2018

Conversation

kozlovic
Copy link
Contributor

@kozlovic kozlovic commented Mar 1, 2018

Details can be found here

@yosifkit
Copy link
Member

yosifkit commented Mar 1, 2018

Diff:
diff --git a/_bashbrew-arches b/_bashbrew-arches
index 21d5aaa..e2ba2c1 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -1,4 +1,5 @@
 nats:linux @ amd64
+nats:linux @ arm32v6
 nats:linux @ arm32v7
 nats:linux @ arm64v8
 nats:nanoserver @ windows-amd64
diff --git a/_bashbrew-list b/_bashbrew-list
index 4ae8303..0aea864 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,7 +1,7 @@
-nats:1.0.4
-nats:1.0.4-linux
-nats:1.0.4-nanoserver
-nats:1.0.4-windowsservercore
+nats:1.0.6
+nats:1.0.6-linux
+nats:1.0.6-nanoserver
+nats:1.0.6-windowsservercore
 nats:latest
 nats:linux
 nats:nanoserver
diff --git a/_bashbrew-shared-tags b/_bashbrew-shared-tags
index 7ea8499..8a84b14 100644
--- a/_bashbrew-shared-tags
+++ b/_bashbrew-shared-tags
@@ -1,2 +1,2 @@
-nats:1.0.4 -- nats:linux, nats:nanoserver
+nats:1.0.6 -- nats:linux, nats:nanoserver
 nats:latest -- nats:linux, nats:nanoserver

@yosifkit
Copy link
Member

yosifkit commented Mar 1, 2018

Build test of #4068; 5c18445; amd64 (nats):

$ bashbrew build nats:1.0.6-linux
Building bashbrew/cache:e3bb724c7d8075c3e77615bc6fcf94b0d6f3db3151aceb2cdea3d4405a39cbe0 (nats:1.0.6-linux)
Tagging nats:1.0.6-linux
Tagging nats:linux
Tagging nats:1.0.6
Tagging nats:latest

$ test/run.sh nats:1.0.6-linux
testing nats:1.0.6-linux
	'cve-2014--shellshock' [1/2]...passed
	'override-cmd' [2/2]...image does not appear to contain "echo" -- assuming single-binary image
passed


$ bashbrew build nats:1.0.6-nanoserver
skipping "nats:1.0.6-nanoserver" (due to architecture "amd64"; only "windows-amd64" supported)

$ test/run.sh nats:1.0.6-nanoserver
testing nats:1.0.6-nanoserver
	image does not exist!


$ bashbrew build nats:1.0.6-windowsservercore
skipping "nats:1.0.6-windowsservercore" (due to architecture "amd64"; only "windows-amd64" supported)

$ test/run.sh nats:1.0.6-windowsservercore
testing nats:1.0.6-windowsservercore
	image does not exist!

The following images failed at least one test:

  • nats:
    • nats:1.0.6-nanoserver
    • nats:1.0.6-windowsservercore

@yosifkit yosifkit merged commit a513d74 into docker-library:master Mar 1, 2018
@kozlovic
Copy link
Contributor Author

kozlovic commented Mar 2, 2018

@yosifkit Seem like the arm32v6 image is missing and looking at the log it failed to build: https://doi-janky.infosiftr.net/job/multiarch/job/arm32v6/job/nats/
That being said, I cannot say if this is something on my side or not. Any idea? Thanks!

@yosifkit
Copy link
Member

yosifkit commented Mar 2, 2018

Sending build context to Docker daemon  10.24kB

Step 1/6 : FROM scratch
 ---> 
Step 2/6 : COPY gnatsd /gnatsd
COPY failed: stat /var/lib/docker/tmp/docker-builder721683265/gnatsd: no such file or directory

That would be because there is no gnatsd executable in the arm32v6 directory for that commit (ie master). So you'll need to add it and make a PR to update the library file.

@kozlovic
Copy link
Contributor Author

kozlovic commented Mar 2, 2018

@yosifkit I completely messed-up, I did submit the PR here before actually updating the nats-docker repo with the new image. So basically docker image says 1.0.6 but actual exe is still 1.0.4. In the process of updating nats-docker now. Will the docker images be all replaced with the new exe? The problem will be for people that pulled the image between yesterday and today (once it is merged).

@yosifkit
Copy link
Member

yosifkit commented Mar 2, 2018

Yeah, if the docker tag names are the same then they will just be replaced by new image pushes.

@kozlovic
Copy link
Contributor Author

kozlovic commented Mar 2, 2018

@yosifkit I resubmitted as PR #4084. Can I ask you a favor and review asap to minimize the risk of people pulling 1.0.6 with 1.0.4 exe :-( thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants