Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memcached #380

Merged
merged 1 commit into from
Dec 31, 2014
Merged

Add memcached #380

merged 1 commit into from
Dec 31, 2014

Conversation

yosifkit
Copy link
Member

Fixes #80.

@yosifkit
Copy link
Member Author

Build test of #380; 2cd4d08 (memcached):

$ ./bashbrew/bashbrew.sh build https://raw.githubusercontent.com/docker-library/official-images/2cd4d083d131867326b199291eb76ec0a8cb6ccc/library/memcached
Cloning memcached (git://github.com/docker-library/memcached) ...
Processing memcached:1.4.21 ...
Processing memcached:1.4 ...
Processing memcached:1 ...
Processing memcached:latest ...

@tianon
Copy link
Member

tianon commented Dec 31, 2014

LGTM

tianon added a commit that referenced this pull request Dec 31, 2014
@tianon tianon merged commit 9c4d122 into docker-library:master Dec 31, 2014
@tianon tianon deleted the memcached branch December 31, 2014 23:44
@md5
Copy link
Contributor

md5 commented Dec 31, 2014

Did you guys think about any ways to deal with the SIGTERM issue from memcached/memcached#88?

@md5
Copy link
Contributor

md5 commented Dec 31, 2014

It might be good to open a known issue against docker-library/memcached documenting the fact that stopping this container will end up being done ungracefully.

@yosifkit
Copy link
Member Author

Just adding documentation for it right now. docker-library/docs#132

@md5
Copy link
Contributor

md5 commented Dec 31, 2014

I added docker-library/memcached#1 since this should hopefully be fixed at some point.

@tianon
Copy link
Member

tianon commented Jan 1, 2015

You rock @md5; thanks for being on top of the SIGTERM issues here. 👍

@md5
Copy link
Contributor

md5 commented Jan 1, 2015

Glad to help. I'm just happy to see more and more of the kinks getting worked out of the official Docker images so I have less cases where I need to create images myself from scratch.

legolaz8451 pushed a commit to legolaz8451/official-images that referenced this pull request Mar 14, 2024
Version 3.4 is end of life Jan 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

library: can memcached be added?
3 participants