-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redis 4.0.0 #3196
Merged
Merged
Add Redis 4.0.0 #3196
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,59 +1,47 @@ | ||
| # this file is generated via https://github.com/docker-library/redis/blob/016e0d738031c00bb6cfa4a433e763413e14b757/generate-stackbrew-library.sh | ||
| # this file is generated via https://github.com/docker-library/redis/blob/f610cf8906e0e1f6b4fbe37584e2d6051a3f6fc0/generate-stackbrew-library.sh | ||
|
|
||
| Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon), | ||
| Joseph Ferguson <yosifkit@gmail.com> (@yosifkit) | ||
| GitRepo: https://github.com/docker-library/redis.git | ||
|
|
||
| Tags: 3.0.7, 3.0 | ||
| Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x | ||
| GitCommit: fa0e115934f352cbfa8d0d471b43a18e865e28b3 | ||
| Directory: 3.0 | ||
|
|
||
| Tags: 3.0.7-32bit, 3.0-32bit | ||
| Architectures: amd64 | ||
| GitCommit: fa0e115934f352cbfa8d0d471b43a18e865e28b3 | ||
| Directory: 3.0/32bit | ||
|
|
||
| Tags: 3.0.7-alpine, 3.0-alpine | ||
| Architectures: amd64 | ||
| GitCommit: fa0e115934f352cbfa8d0d471b43a18e865e28b3 | ||
| Directory: 3.0/alpine | ||
|
|
||
| Tags: 3.0.504-windowsservercore, 3.0-windowsservercore | ||
| Architectures: windows-amd64 | ||
| GitCommit: ad72d7a7f3c05a9b658ec64894d4193c89bba01b | ||
| Directory: 3.0/windows/windowsservercore | ||
| Constraints: windowsservercore | ||
|
|
||
| Tags: 3.0.504-nanoserver, 3.0-nanoserver | ||
| Architectures: windows-amd64 | ||
| GitCommit: ad72d7a7f3c05a9b658ec64894d4193c89bba01b | ||
| Directory: 3.0/windows/nanoserver | ||
| Constraints: nanoserver | ||
|
|
||
| Tags: 3.2.9, 3.2, 3, latest | ||
| Tags: 3.2.9, 3.2, 3 | ||
| Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x | ||
| GitCommit: f131897d1f6305b8f6ebae695344f19c523e2c65 | ||
| Directory: 3.2 | ||
|
|
||
| Tags: 3.2.9-32bit, 3.2-32bit, 3-32bit, 32bit | ||
| Tags: 3.2.9-32bit, 3.2-32bit, 3-32bit | ||
| Architectures: amd64 | ||
| GitCommit: f131897d1f6305b8f6ebae695344f19c523e2c65 | ||
| Directory: 3.2/32bit | ||
|
|
||
| Tags: 3.2.9-alpine, 3.2-alpine, 3-alpine, alpine | ||
| Tags: 3.2.9-alpine, 3.2-alpine, 3-alpine | ||
| Architectures: amd64 | ||
| GitCommit: f131897d1f6305b8f6ebae695344f19c523e2c65 | ||
| Directory: 3.2/alpine | ||
|
|
||
| Tags: 3.2.100-windowsservercore, 3.2-windowsservercore, 3-windowsservercore, windowsservercore | ||
| Tags: 3.2.100-windowsservercore, 3.2-windowsservercore, 3-windowsservercore | ||
| Architectures: windows-amd64 | ||
| GitCommit: f131897d1f6305b8f6ebae695344f19c523e2c65 | ||
| Directory: 3.2/windows/windowsservercore | ||
| Constraints: windowsservercore | ||
|
|
||
| Tags: 3.2.100-nanoserver, 3.2-nanoserver, 3-nanoserver, nanoserver | ||
| Tags: 3.2.100-nanoserver, 3.2-nanoserver, 3-nanoserver | ||
| Architectures: windows-amd64 | ||
| GitCommit: f131897d1f6305b8f6ebae695344f19c523e2c65 | ||
| Directory: 3.2/windows/nanoserver | ||
| Constraints: nanoserver | ||
|
|
||
| Tags: 4.0.0, 4.0, 4, latest | ||
| Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x | ||
| GitCommit: f610cf8906e0e1f6b4fbe37584e2d6051a3f6fc0 | ||
| Directory: 4.0 | ||
|
|
||
| Tags: 4.0.0-32bit, 4.0-32bit, 4-32bit, 32bit | ||
| Architectures: amd64 | ||
| GitCommit: f610cf8906e0e1f6b4fbe37584e2d6051a3f6fc0 | ||
| Directory: 4.0/32bit | ||
|
|
||
| Tags: 4.0.0-alpine, 4.0-alpine, 4-alpine, alpine | ||
| Architectures: amd64 | ||
| GitCommit: f610cf8906e0e1f6b4fbe37584e2d6051a3f6fc0 | ||
| Directory: 4.0/alpine | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth noting that https://github.com/MSOpenTech/redis now redirects to https://github.com/MicrosoftArchive/redis ("Archived Microsoft GitHub repositories - for historical interest, not actively maintained"), so even these older Windows tags might be something we should look to remove in the future. 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the loss of the plain
nanoserverandwindowsservercoretags?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
latestmoved toredis:4.0, and there's no Windows version of 4.0 (related to this archiving).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But they should still exist. Just because windows is behind doesn't mean its latest tag should be lost; we have let other images get out of sync in their versions between OS's (Debian vs Alpine).
If we need to look at removing or finding a new source for the windows based images, that can be done separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even sure how we'd implement that in the generate script -- I'd be much more inclined to just remove all the Windows images, personally. I never really liked that their versions didn't match up, so them being unmaintained is just another nail in the coffin, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we had a case where the major version number of two variants weren't in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(IMO, it'd be weird as a user for
redis:latestto give me Redis 4.x butredis:nanoserverto give me 3.x, if both are still claimed to be supported -- I think microsoftarchive/redis#525 makes it pretty clear that the future of Redis on Windows is tenuous at best. Maybe one of our RedisLabs maintainers could comment on whether the Windows variants should simply go away at this point?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes Microsoft and maintainers has confirmed it is no longer maintaining the redis on windows last year. There won't be a 4.0 port for Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redis/docker-library-redis#99