Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on whitespace at end of lines #232

Merged
merged 3 commits into from
Oct 2, 2014

Conversation

yosifkit
Copy link
Member

@yosifkit yosifkit commented Oct 2, 2014

This will prevent the whitespace from propagating into the docs links to the dockerfiles.

gitRef="${commitDir%% *}"
gitDir="${commitDir#* }"
if [ "$gitDir" = "$commitDir" ]; then
gitDir=''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just gitDir= like we do elsewhere in this script?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for example, line 122)

@tianon
Copy link
Member

tianon commented Oct 2, 2014

LGTM

tianon added a commit that referenced this pull request Oct 2, 2014
Fail on whitespace at end of lines
@tianon tianon merged commit 70012bb into docker-library:master Oct 2, 2014
@tianon tianon deleted the whitespaaace branch October 2, 2014 03:02
Nexucis pushed a commit to Nexucis/official-images that referenced this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants