Add jurby

[cpuguy83]

No description provided.

[yosifkit]

A few questions:

• Is there a way to verify the downloaded tarball?
• If we are not going to verify it, we can just pipe the wget straight to tar.
  • wget http://jruby.org.s3.amazonaws.com/downloads/${JRUBY_VERSION}/jruby-bin-${JRUBY_VERSION}.tar.gz | tar -zx -C /opt/jruby --strip-components=1
  • this keeps version number out of the path

[cpuguy83]

Verify as in through a checksum?

[yosifkit]

I was hoping for something like a gpg signature.

[cpuguy83]

I don't think GPG, but sha1 and md5 hashes are available, I can use that.

[yosifkit]

That is fine, but doesn't really increase the trust in the downloaded file, just that it is not corrupted.

[tianon]

Yeah, I think verifying MD5 or SHA1 is overkill here. It'll fail to extract if there's a transmission issue, which is good enough, IMO. GPG verification is awesome when it's available, but when it's not we just streamline the process of getting and extracting as much as we can.

[cpuguy83]

So, any action items here?

[tianon]

I'd say if we replace:

RUN cd /tmp && wget http://jruby.org.s3.amazonaws.com/downloads/${JRUBY_VERSION}/jruby-bin-${JRUBY_VERSION}.tar.gz \
  && cd /opt && tar -zxvf /tmp/jruby-bin-${JRUBY_VERSION}.tar.gz \
  && rm /tmp/jruby-bin-${JRUBY_VERSION}.tar.gz
ENV PATH /opt/jruby-${JRUBY_VERSION}/bin:$PATH

with:

RUN wget http://jruby.org.s3.amazonaws.com/downloads/${JRUBY_VERSION}/jruby-bin-${JRUBY_VERSION}.tar.gz \
    | tar -zxC /opt/jruby --strip-components=1
ENV PATH /opt/jruby/bin:$PATH

then it'd LGTM (and be simpler for you to mangle in future updates, too).

The library file format here LGTM too.

[cpuguy83]

Updated PTAL

[tianon]

Gotta update the commit hash here to da39f6ba4489618cb1bc2004dcc63912d430c310 too. 😄

(but the Dockerfile change LGTM - once the library file is updated I'll do a test build)

[cpuguy83]

Of course :) I've explained this enough to other people, you'd think I could do it myself.

[cpuguy83]

And done, btw.

[yosifkit]

LGTM

@tianon?

[tianon]

LGTM

root@927fca0f00f7:/usr/src/stackbrew# ./brew-cli --debug --no-namespace -b master --targets jruby git://github.com/cpuguy83/official-images.git  
2014-09-24 15:29:59,398 DEBUG Cloning repo_url=git://github.com/cpuguy83/official-images.git, ref=master
2014-09-24 15:29:59,400 DEBUG folder = /tmp/tmp7vi3Sz
2014-09-24 15:29:59,400 DEBUG Cloning git://github.com/cpuguy83/official-images.git into /tmp/tmp7vi3Sz
2014-09-24 15:29:59,400 DEBUG Executing "git clone git://github.com/cpuguy83/official-images.git ." in /tmp/tmp7vi3Sz
Cloning into '.'...
remote: Counting objects: 1357, done.
remote: Compressing objects: 100% (582/582), done.
remote: Total 1357 (delta 767), reused 1352 (delta 763)
Receiving objects: 100% (1357/1357), 201.95 KiB | 0 bytes/s, done.
Resolving deltas: 100% (767/767), done.
Checking connectivity... done.
2014-09-24 15:30:00,641 DEBUG Checkout ref:master in /tmp/tmp7vi3Sz
2014-09-24 15:30:00,641 DEBUG Executing "git checkout master" in /tmp/tmp7vi3Sz
Already on 'master'
Your branch is up-to-date with 'origin/master'.
2014-09-24 15:30:00,647 DEBUG 1.7: git://github.com/cpuguy83/docker-jruby@53d1d6ec2bc99ef884d60aa756861234710f2bbc 1.7

2014-09-24 15:30:00,647 DEBUG 1.7.15: git://github.com/cpuguy83/docker-jruby@53d1d6ec2bc99ef884d60aa756861234710f2bbc 1.7

2014-09-24 15:30:00,647 DEBUG latest: git://github.com/cpuguy83/docker-jruby@53d1d6ec2bc99ef884d60aa756861234710f2bbc 1.7

2014-09-24 15:30:00,647 DEBUG 1.7-onbuild: git://github.com/cpuguy83/docker-jruby@53d1d6ec2bc99ef884d60aa756861234710f2bbc 1.7/onbuild

2014-09-24 15:30:00,647 DEBUG 1.7.15-onbuild: git://github.com/cpuguy83/docker-jruby@53d1d6ec2bc99ef884d60aa756861234710f2bbc 1.7/onbuild

2014-09-24 15:30:00,647 DEBUG onbuild: git://github.com/cpuguy83/docker-jruby@53d1d6ec2bc99ef884d60aa756861234710f2bbc 1.7/onbuild

2014-09-24 15:30:00,647 DEBUG jruby: 1.7,1.7.15,latest
2014-09-24 15:30:00,647 DEBUG jruby: 1.7-onbuild,1.7.15-onbuild,onbuild
2014-09-24 15:30:00,647 DEBUG Cloning repo_url=git://github.com/cpuguy83/docker-jruby, ref=53d1d6ec2bc99ef884d60aa756861234710f2bbc
2014-09-24 15:30:00,647 DEBUG folder = /tmp/tmpDu29M0
2014-09-24 15:30:00,647 DEBUG Cloning git://github.com/cpuguy83/docker-jruby into /tmp/tmpDu29M0
2014-09-24 15:30:00,647 DEBUG Executing "git clone git://github.com/cpuguy83/docker-jruby ." in /tmp/tmpDu29M0
Cloning into '.'...
remote: Counting objects: 10, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 10 (delta 1), reused 10 (delta 1)
Receiving objects: 100% (10/10), done.
Resolving deltas: 100% (1/1), done.
Checking connectivity... done.
2014-09-24 15:30:01,100 DEBUG Checkout ref:53d1d6ec2bc99ef884d60aa756861234710f2bbc in /tmp/tmpDu29M0
2014-09-24 15:30:01,100 DEBUG Executing "git checkout 53d1d6ec2bc99ef884d60aa756861234710f2bbc" in /tmp/tmpDu29M0
Note: checking out '53d1d6ec2bc99ef884d60aa756861234710f2bbc'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 53d1d6e... Initial commit
2014-09-24 15:30:01,105 INFO Build start: jruby ('git://github.com/cpuguy83/docker-jruby', '53d1d6ec2bc99ef884d60aa756861234710f2bbc', '1.7')
2014-09-24 15:30:47,054 INFO Build success: 54802c598146 (jruby:1.7)
2014-09-24 15:30:47,090 INFO Build success: 54802c598146 (jruby:1.7.15)
2014-09-24 15:30:47,125 INFO Build success: 54802c598146 (jruby:latest)
2014-09-24 15:30:47,199 DEBUG Checkout ref:53d1d6ec2bc99ef884d60aa756861234710f2bbc in /tmp/tmpDu29M0
2014-09-24 15:30:47,199 DEBUG Executing "git checkout 53d1d6ec2bc99ef884d60aa756861234710f2bbc" in /tmp/tmpDu29M0
HEAD is now at 53d1d6e... Initial commit
2014-09-24 15:30:47,203 INFO Build start: jruby ('git://github.com/cpuguy83/docker-jruby', '53d1d6ec2bc99ef884d60aa756861234710f2bbc', '1.7/onbuild')
2014-09-24 15:30:52,576 INFO Build success: 9420fe9ef048 (jruby:1.7-onbuild)
2014-09-24 15:30:52,609 INFO Build success: 9420fe9ef048 (jruby:1.7.15-onbuild)
2014-09-24 15:30:52,662 INFO Build success: 9420fe9ef048 (jruby:onbuild)

root@927fca0f00f7:/usr/src/stackbrew# docker images jruby
REPOSITORY          TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
jruby               onbuild             9420fe9ef048        8 seconds ago       668.4 MB
jruby               1.7-onbuild         9420fe9ef048        8 seconds ago       668.4 MB
jruby               1.7.15-onbuild      9420fe9ef048        8 seconds ago       668.4 MB
jruby               latest              54802c598146        14 seconds ago      668.4 MB
jruby               1.7                 54802c598146        14 seconds ago      668.4 MB
jruby               1.7.15              54802c598146        14 seconds ago      668.4 MB

[tianon]

@cpuguy83 would you mind making a small PR to https://github.com/docker-library/docs with a jruby/README-short.txt (no more than 200 characters) and a jruby/content.md with a format somewhat similar to the existing ruby/content.md? 😄

It'd probably be good to note somewhere in there what makes jruby different from just ruby (either in the short description, or in the # What is JRuby? initial section).

[tianon]

Oh, and when you get a chance, you should add a LICENSE to your repo. We recommend you either go with your upstream's license or Expat/MIT/X11.

[tianon]

Arg, we definitely need a solid, simple checklist. We ought to have a jruby/license.md too (which notes the upstream license) and a jruby/logo.png (which is either widely recognizable or includes the name of the upstream in text form).