Skip to content

Conversation

jimmycuadra
Copy link
Contributor

@yosifkit
Copy link
Member

Changeset: containous/traefik-library-image@04d09c3...0b0c26d

LGTM,Build test of #1745; 46b216a (traefik):

$ bashbrew build "traefik"
Cloning traefik (git://github.com/containous/traefik-library-image) ...
Processing traefik:v1.0.0-beta.704 ...
Processing traefik:v1.0.0-beta.404 ...
Processing traefik:v1.0.0-beta.392 ...
Processing traefik:latest ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing traefik:v1.0.0-beta.704
    'cve-2014--shellshock' [1/1]...passed
testing traefik:v1.0.0-beta.404
    'cve-2014--shellshock' [1/1]...passed
testing traefik:v1.0.0-beta.392
    'cve-2014--shellshock' [1/1]...passed

@yosifkit yosifkit merged commit 6748343 into docker-library:master May 17, 2016
@emilevauge
Copy link
Contributor

@jimmycuadra, @yosifkit, it would have been great to ping the maintainers before merging this one ;) :

# maintainer: Emile Vauge <emile@vauge.com> (@emilevauge)
# maintainer: Vincent Demeester <vincent@sbr.pm> (@vdemeester)

I was not aware that a new version had been pushed.

@jimmycuadra
Copy link
Contributor Author

My bad, I was trying to save you the trouble, since I wanted a version with Kubernetes support and it was trivial to do this PR myself.

@emilevauge
Copy link
Contributor

np, I understand :)
But it can happen that a particular build is known to contain issues. Then I prefer being aware in case a "bad" build is being merged ;)

@yosifkit
Copy link
Member

@emilevauge, my bad, I usually check that the PR is from a maintainer. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants