Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rails library with latest image #1554

Merged
merged 2 commits into from
Mar 18, 2016
Merged

Update rails library with latest image #1554

merged 2 commits into from
Mar 18, 2016

Conversation

Yanchek99
Copy link
Contributor

@yosifkit
Copy link
Member

Thanks for your help!

This file can be generated from ./generate-stackbrew-library.sh in the ruby repo, can you update the other commit ids as well?

$ ./generate-stackbrew-library.sh
# maintainer: InfoSiftr <github@infosiftr.com> (@infosiftr)

4.2.6: git://github.com/docker-library/rails@04006011344175c10b6864193eee74d626b84b11
4.2: git://github.com/docker-library/rails@04006011344175c10b6864193eee74d626b84b11
4: git://github.com/docker-library/rails@04006011344175c10b6864193eee74d626b84b11
latest: git://github.com/docker-library/rails@04006011344175c10b6864193eee74d626b84b11

onbuild: git://github.com/docker-library/rails@9df9b5e6b1519faf22e1565c2caaebf7cc1c665b onbuild

Edit: it is also grabbing the commit that changed the file rather than just the newest commit.

Leveraging the result from generate-stackbrew-library.sh script in the
rails repo.
@Yanchek99
Copy link
Contributor Author

@yosifkit No problem and sorry about the manual change. Guess I was going to fast to realize there was a handy script for that.

@tianon
Copy link
Member

tianon commented Mar 18, 2016

LGTM

Build test of #1554; c33d489 (rails):

$ bashbrew build "rails"
Cloning rails (git://github.com/docker-library/rails) ...
Processing rails:4.2.6 ...
Processing rails:4.2 ...
Processing rails:4 ...
Processing rails:latest ...
Processing rails:onbuild ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing rails:4.2.6
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing rails:onbuild
    'override-cmd' [1/1]...passed

tianon added a commit that referenced this pull request Mar 18, 2016
Update rails library with latest image
@tianon tianon merged commit 60e5478 into docker-library:master Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants