Odoo: Build for arm64 too

[samip5]

I believe this should be just a matter of including them here.

[github-actions]

Diff for 65a00a6:

diff --git a/_bashbrew-arches b/_bashbrew-arches
index 21d5bd8..e85a97f 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -1 +1,2 @@
 amd64
+arm64v8
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 3137fa7..08420bc 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -3,10 +3,13 @@ GitRepo: https://github.com/odoo/docker
 GitCommit: 61148a86eed7fb5452dc7705b479988e1f49f9a6
 
 Tags: 14.0, 14
+Architectures: amd64, arm64v8
 Directory: 14.0
 
 Tags: 15.0, 15
+Architectures: amd64, arm64v8
 Directory: 15.0
 
 Tags: 16.0, 16, latest
+Architectures: amd64, arm64v8
 Directory: 16.0

Relevant Maintainers:

• odoo: @d-fence

[derfl0]

I don't want to break your enthusiasm @samip5 but running an amd64 packet on arm64 will not work:
https://github.com/odoo/docker/blob/master/16.0/Dockerfile#L36

[samip5]

I don't want to break your enthusiasm @samip5 but running an amd64 packet on arm64 will not work: https://github.com/odoo/docker/blob/master/16.0/Dockerfile#L36

Yeah, just noticed that and I also noticed that odoo/docker#410 (comment) which means @d-fence might not want to use the version that's available for arm64 :(

There's also an PR for fixing that at least for Odoo 16:

• [FIX] Odoo 16.0: failed to build on Mac Apple-Chip odoo/docker#464

[yosifkit]

Without the Odoo Dockerfiles being updated to support building on multiple architectures, this PR will not work. As for odoo/docker#464, that is only part of a fix since it would then fail to build on amd64. It is up to the Odoo image maintainer, @d-fence, but it would likely need something like this section in the golang Dockerfile that uses dpkg to get the userspace architecture and then chooses the architecture-specific item to download:

https://github.com/docker-library/golang/blob/18778673d05af968094fe71d45dfd7fbf1856b65/1.21/bookworm/Dockerfile#L26-L79

---

A simple way to test architectures that you do not have access to is to use Docker Desktop (and it sets up qemu): docker build --platform=linux/arm64 16.0/. Alternatively, installing binfmt-support and qemu-user-static in a Debian host OS running Docker and you can do the same docker build --platform. We have seen issues when using qemu user static to emulate other architectures, so while it isn't a full replacement for actual hardware 😢, it is still helpful if you don't have them.

[ludovic-gasc]

The support of ARM for Odoo is now available if you want to test: https://hub.docker.com/search?q=odoo&image_filter=official

[rfc2119]

@ludovic-gasc Any idea how are the images built for arm64 ? I don't think the current Dockerfile is multiarch

[tianon]

The current Dockerfile is multiarch (and built for multiarch):

$ crane manifest odoo | jq '.manifests[].platform | select(.os != "unknown")'
{
  "architecture": "amd64",
  "os": "linux"
}
{
  "architecture": "arm64",
  "os": "linux",
  "variant": "v8"
}
{
  "architecture": "ppc64le",
  "os": "linux"
}

[rfc2119]

Yes, but I don't see how this line will fit for both arm64 and amd64 packages from the nightly archive
https://github.com/odoo/docker/blob/b6411dfc5391faaa18a0e12951adcbc3469c2a30/17.0/Dockerfile#L76

[samip5]

Yes, but I don't see how this line will fit for both arm64 and amd64 packages from the nightly archive https://github.com/odoo/docker/blob/b6411dfc5391faaa18a0e12951adcbc3469c2a30/17.0/Dockerfile#L76

It's the way the Docker's build system uses targetarch ARG, and builds it according to that, so you'll not see arch specific instructions in most cases.
That deb package also is not arch specific as the thing packaged is a Python application.

[rfc2119]

That deb package also is not arch specific as the thing packaged is a Python application.

TIL. Interesting.