Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry:latest to point to registry 2.x #1391

Closed

Conversation

aaronlehmann
Copy link
Contributor

The registry:latest tag currently points to registry 0.9.1. It has been
pointing to this old version for awhile to avoid breaking users
following outdated legacy registry documentation. Registry 2.x is
well-established now, and the time has come to change the latest tag.
Change it so that registry:latest is synonymous with registry:2.

Remove old 0.8.1 and 0.9.1 tags from the file.

cc @docker/distribution-maintainers

@yosifkit
Copy link
Member

If 0.8.1 and 0.9.1 are not getting any updates, they might as well dropped from the list. This will not prevent them from being pulled as the images will still exist on the Docker Hub. This will remove them from the "Supported tags and respective Dockerfile links" section and would prevent them from being rebuilt when ubuntu images are updated.

I think this will need to be addressed as well: #643 (comment).

@dmp42
Copy link
Contributor

dmp42 commented Jan 28, 2016

Thanks @yosifkit

The 0.X won't get any update in the future, so, I guess we can drop them.

Also, we can continue our previous conversation here: distribution/distribution#504 (comment)

The registry:latest tag currently points to registry 0.9.1. It has been
pointing to this old version for awhile to avoid breaking users
following outdated legacy registry documentation. Registry 2.x is
well-established now, and the time has come to change the latest tag.
Change it so that registry:latest is synonymous with registry:2.

Remove old 0.8.1 and 0.9.1 tags from the file.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@aaronlehmann
Copy link
Contributor Author

Updated to remove references to 0.8.1 and 0.9.1.

@RichardScothern
Copy link

LGTM. @yosifkit : can you merge so I can update for the new registry release please?

@tianon
Copy link
Member

tianon commented Feb 4, 2016

As agreed upon in #643 (comment), latest should not change until the consistency issue is addressed. I'm happy to help address it, and am willing to do the work to maintain the script in the long run if issues with it or new requirements come up. I'm also willing to debate the standards for acceptance if there's a good discussion to be had there, but that is a separate, orthogonal discussion that is IMO not appropriate to be having in this context -- we should open a new issue to discuss that.

The best course of action to get 2.3 built and released ASAP is going to be to put this PR on the back-burner for now and just update the 2.x references, returning to this PR once the agreed-upon modifications are in place to make this acceptable.

@RichardScothern
Copy link

@tianon : Let's leave that discussion for now. I will revert the change to latest in #1418 for this release. Is that OK?

@tianon
Copy link
Member

tianon commented Feb 4, 2016

@RichardScothern that sounds perfect, thanks! 👍 (I think we cross-commented at roughtly the same time 😄)

@RichardScothern
Copy link

@yosifkit : we would like to base the registry image on Alpine linux. As we ship a bare binary, there is little need to have a few hundred megabytes of extra stuff.

Given that Alpine does not come installed with bash this does not meet the ability to run with bash requirement. Like swarm, cirros, busybox etc, can we drop this requirement to reclaim the latest tag for the registry?

@yosifkit
Copy link
Member

Alpine Linux would not remove that requirement. There is still a shell and many other programs available. More info in distribution/distribution#504 (comment). Let's continue the discussion there.

@tianon
Copy link
Member

tianon commented Jun 29, 2016

Since this is still open, it's worth noting that #1838 added 2.5.0-rc.1 which fixes this issue, so I'm guessing latest will return when 2.5.0 goes GA? 😄 🎉 🎈

@RichardScothern
Copy link

Correct. I didn't close this since we're still in rc. 👍

@yosifkit
Copy link
Member

This was fixed in #1991. 🎉

@yosifkit yosifkit closed this Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants