Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily downgrade Notary to Alpine 3.12 #12374

Merged
merged 1 commit into from
May 6, 2022

Conversation

tianon
Copy link
Member

@tianon tianon commented May 5, 2022

We need to build Notary 0.7.0 with an older version of Go, and Alpine 3.12 has an old enough version. There should be a new release of Notary soon which will fix the incompatibility and allow us to go back to Alpine 3.15.

See docker/notary-official-images#28

We need to build Notary 0.7.0 with an older version of Go, and Alpine 3.12 has an old enough version.  There *should* be a new release of Notary soon which will fix the incompatibility and allow us to go back to Alpine 3.15.
@github-actions
Copy link

github-actions bot commented May 5, 2022

Diff for ead6f06:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index e95bc57..998f75e 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,7 +1,7 @@
 Maintainers: Justin Cormack (@justincormack)
 Architectures: amd64, arm32v6, arm64v8, i386, ppc64le, s390x
 GitRepo: https://github.com/docker/notary-official-images.git
-GitCommit: 297f548a568a8bcf8177c10e05165f11c9557dfc
+GitCommit: 16219dbe3c1433a6fc93e016cf421b230f681a2f
 
 Tags: server-0.7.0, server
 Directory: notary-server
diff --git a/notary_server/Dockerfile b/notary_server/Dockerfile
index 579c6d1..f0dab44 100644
--- a/notary_server/Dockerfile
+++ b/notary_server/Dockerfile
@@ -1,4 +1,4 @@
-FROM alpine:3.15
+FROM alpine:3.12
 
 ENV TAG v0.7.0
 ENV NOTARYPKG github.com/theupdateframework/notary
@@ -16,7 +16,7 @@ RUN set -eux; \
     cp -vL ${GOPATH}/src/${NOTARYPKG}/bin/static/notary-server ./; \
     apk del --no-network build-deps; \
     rm -rf ${GOPATH}; \
-    ./notary-server --help
+    ./notary-server --version
 
 COPY ./server-config.json .
 COPY ./entrypoint.sh .
@@ -26,4 +26,4 @@ USER notary
 ENV PATH=$PATH:${INSTALLDIR}
 
 ENTRYPOINT [ "entrypoint.sh" ]
-CMD [ "notary-server", "--help" ]
+CMD [ "notary-server", "--version" ]
diff --git a/notary_signer/Dockerfile b/notary_signer/Dockerfile
index 74cf984..e2be5cb 100644
--- a/notary_signer/Dockerfile
+++ b/notary_signer/Dockerfile
@@ -1,4 +1,4 @@
-FROM alpine:3.15
+FROM alpine:3.12
 
 ENV TAG v0.7.0
 ENV NOTARYPKG github.com/theupdateframework/notary
@@ -17,7 +17,7 @@ RUN set -eux; \
     cp -vL ${GOPATH}/src/${NOTARYPKG}/bin/static/notary-signer ./; \
     apk del --no-network build-deps; \
     rm -rf ${GOPATH}; \
-    ./notary-signer --help
+    ./notary-signer --version
 
 COPY ./signer-config.json .
 COPY ./entrypoint.sh .
@@ -27,4 +27,4 @@ USER notary
 ENV PATH=$PATH:${INSTALLDIR}
 
 ENTRYPOINT [ "entrypoint.sh" ]
-CMD [ "notary-signer", "--help" ]
+CMD [ "notary-signer", "--version" ]

Relevant Maintainers:

@yosifkit yosifkit merged commit 376a98c into docker-library:master May 6, 2022
@yosifkit yosifkit deleted the notary branch May 6, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants