Revert websphere-liberty to using IBM JRE #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm given to understand that export controls are now in place on Docker Hub so we can revert the websphere-liberty image back to using an IBM JRE.
|
Changeset: WASdev/ci.docker@9da673b...975e98c LGTM, Build test of #1117; 77d8d9c ( $ url="https://raw.githubusercontent.com/docker-library/official-images/77d8d9cb881423b184a9f439aa190d8aa7787bd2/library/websphere-liberty"
$ bashbrew build "$url"
Fetching websphere-liberty (git://github.com/WASdev/ci.docker) ...
Processing websphere-liberty:kernel ...
Processing websphere-liberty:8.5.5.7-kernel ...
Processing websphere-liberty:common ...
Processing websphere-liberty:8.5.5.7-common ...
Processing websphere-liberty:webProfile6 ...
Processing websphere-liberty:8.5.5.7-webProfile6 ...
Processing websphere-liberty:webProfile7 ...
Processing websphere-liberty:8.5.5.7-webProfile7 ...
Processing websphere-liberty:javaee7 ...
Processing websphere-liberty:8.5.5.7-javaee7 ...
Processing websphere-liberty:8.5.5.7 ...
Processing websphere-liberty:8.5.5 ...
Processing websphere-liberty:latest ...
Processing websphere-liberty:beta ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing websphere-liberty:kernel
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...failed
testing websphere-liberty:common
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...failed
testing websphere-liberty:webProfile6
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...failed
testing websphere-liberty:webProfile7
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...failed
testing websphere-liberty:javaee7
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...failed
testing websphere-liberty:beta
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...failedThere is at least one failure in the above build log. |
|
Disclaimer: I have no knowledge of the export controls available on Docker Hub or if they need a request to turn on. |
|
Yeah, the diff seems fine (LGTM), but we don't know anything about export controls. 😄 @davidcurrie do you want us to wait while you verify whether anything extra needs to be done, or just merge? |
|
Please go ahead and merge. We had a support ticket that indicated the
export controls work has been done.
|
yosifkit
added a commit
that referenced
this pull request
Oct 13, 2015
Revert websphere-liberty to using IBM JRE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm given to understand that export controls are now in place on Docker Hub so we can revert the websphere-liberty image back to using an IBM JRE.