Releasing Neo4j 4.3.6

[jennyowen]

Thanks!

[github-actions]

Diff for 1c1336c:

diff --git a/_bashbrew-cat b/_bashbrew-cat
index 0b75a8a..8928485 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -510,12 +510,22 @@ GitRepo: https://github.com/neo4j/docker-neo4j-publish.git
 GitCommit: 2953846f3588940f44fa1e237e103920786c4709
 Directory: 4.3.4/enterprise
 
-Tags: 4.3.5, 4.3.5-community, 4.3, 4.3-community, community, latest
+Tags: 4.3.5, 4.3.5-community
 GitRepo: https://github.com/neo4j/docker-neo4j-publish.git
 GitCommit: 2c2eb111659ce0474ddd9ff0ce4d925214f42ecd
 Directory: 4.3.5/community
 
-Tags: 4.3.5-enterprise, 4.3-enterprise, enterprise
+Tags: 4.3.5-enterprise
 GitRepo: https://github.com/neo4j/docker-neo4j-publish.git
 GitCommit: 2c2eb111659ce0474ddd9ff0ce4d925214f42ecd
 Directory: 4.3.5/enterprise
+
+Tags: 4.3.6, 4.3.6-community, 4.3, 4.3-community, community, latest
+GitRepo: https://github.com/neo4j/docker-neo4j-publish.git
+GitCommit: 4fe060c8965202c9bb37aba5ffb480e1402a681c
+Directory: 4.3.6/community
+
+Tags: 4.3.6-enterprise, 4.3-enterprise, enterprise
+GitRepo: https://github.com/neo4j/docker-neo4j-publish.git
+GitCommit: 4fe060c8965202c9bb37aba5ffb480e1402a681c
+Directory: 4.3.6/enterprise
diff --git a/_bashbrew-list b/_bashbrew-list
index ae79cc2..2264a5d 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -169,6 +169,9 @@ neo4j:4.3.4-enterprise
 neo4j:4.3.5
 neo4j:4.3.5-community
 neo4j:4.3.5-enterprise
+neo4j:4.3.6
+neo4j:4.3.6-community
+neo4j:4.3.6-enterprise
 neo4j:community
 neo4j:enterprise
 neo4j:latest
diff --git a/neo4j_latest/Dockerfile b/neo4j_4.3.5-community/Dockerfile
similarity index 100%
copy from neo4j_latest/Dockerfile
copy to neo4j_4.3.5-community/Dockerfile
diff --git a/neo4j_4.3.1-community/docker-entrypoint.sh b/neo4j_4.3.5-community/docker-entrypoint.sh
similarity index 100%
copy from neo4j_4.3.1-community/docker-entrypoint.sh
copy to neo4j_4.3.5-community/docker-entrypoint.sh
diff --git a/neo4j_3.5-community/local-package/.sentinel b/neo4j_4.3.5-community/local-package/.sentinel
similarity index 100%
copy from neo4j_3.5-community/local-package/.sentinel
copy to neo4j_4.3.5-community/local-package/.sentinel
diff --git a/neo4j_4.2-community/local-package/neo4jlabs-plugins.json b/neo4j_4.3.5-community/local-package/neo4jlabs-plugins.json
similarity index 100%
copy from neo4j_4.2-community/local-package/neo4jlabs-plugins.json
copy to neo4j_4.3.5-community/local-package/neo4jlabs-plugins.json
diff --git a/neo4j_enterprise/Dockerfile b/neo4j_4.3.5-enterprise/Dockerfile
similarity index 100%
copy from neo4j_enterprise/Dockerfile
copy to neo4j_4.3.5-enterprise/Dockerfile
diff --git a/neo4j_4.3.1-community/docker-entrypoint.sh b/neo4j_4.3.5-enterprise/docker-entrypoint.sh
similarity index 100%
copy from neo4j_4.3.1-community/docker-entrypoint.sh
copy to neo4j_4.3.5-enterprise/docker-entrypoint.sh
diff --git a/neo4j_3.5-community/local-package/.sentinel b/neo4j_4.3.5-enterprise/local-package/.sentinel
similarity index 100%
copy from neo4j_3.5-community/local-package/.sentinel
copy to neo4j_4.3.5-enterprise/local-package/.sentinel
diff --git a/neo4j_4.2-community/local-package/neo4jlabs-plugins.json b/neo4j_4.3.5-enterprise/local-package/neo4jlabs-plugins.json
similarity index 100%
copy from neo4j_4.2-community/local-package/neo4jlabs-plugins.json
copy to neo4j_4.3.5-enterprise/local-package/neo4jlabs-plugins.json
diff --git a/neo4j_enterprise/Dockerfile b/neo4j_enterprise/Dockerfile
index 67c9701..2744c05 100644
--- a/neo4j_enterprise/Dockerfile
+++ b/neo4j_enterprise/Dockerfile
@@ -1,10 +1,10 @@
 FROM openjdk:11-jdk-slim
 
-ENV NEO4J_SHA256=8f05e21f304094ca28cb76bd6f8445e8ccc635e09835e29cf224774082df9a36 \
-    NEO4J_TARBALL=neo4j-enterprise-4.3.5-unix.tar.gz \
+ENV NEO4J_SHA256=aa465470f8229f4a25de8a81ea97879111bb5cf3bdd41806faa065dfd51ddf52 \
+    NEO4J_TARBALL=neo4j-enterprise-4.3.6-unix.tar.gz \
     NEO4J_EDITION=enterprise \
     NEO4J_HOME="/var/lib/neo4j"
-ARG NEO4J_URI=https://dist.neo4j.org/neo4j-enterprise-4.3.5-unix.tar.gz
+ARG NEO4J_URI=https://dist.neo4j.org/neo4j-enterprise-4.3.6-unix.tar.gz
 ARG TINI_SHA256="12d20136605531b09a2c2dac02ccee85e1b874eb322ef6baf7561cd93f93c855"
 ARG TINI_URI="https://github.com/krallin/tini/releases/download/v0.18.0/tini"
 
diff --git a/neo4j_latest/Dockerfile b/neo4j_latest/Dockerfile
index d0988b9..ca60402 100644
--- a/neo4j_latest/Dockerfile
+++ b/neo4j_latest/Dockerfile
@@ -1,10 +1,10 @@
 FROM openjdk:11-jdk-slim
 
-ENV NEO4J_SHA256=86f15fa092630ff0c31e91897dbe93017af95739ba38ba7d4bf2417849f6e6f3 \
-    NEO4J_TARBALL=neo4j-community-4.3.5-unix.tar.gz \
+ENV NEO4J_SHA256=f86e4766097714b57910a5043cbeabf209f69f9e7525da5650640daa2e32f8ad \
+    NEO4J_TARBALL=neo4j-community-4.3.6-unix.tar.gz \
     NEO4J_EDITION=community \
     NEO4J_HOME="/var/lib/neo4j"
-ARG NEO4J_URI=https://dist.neo4j.org/neo4j-community-4.3.5-unix.tar.gz
+ARG NEO4J_URI=https://dist.neo4j.org/neo4j-community-4.3.6-unix.tar.gz
 ARG TINI_SHA256="12d20136605531b09a2c2dac02ccee85e1b874eb322ef6baf7561cd93f93c855"
 ARG TINI_URI="https://github.com/krallin/tini/releases/download/v0.18.0/tini"

Relevant Maintainers:

• neo4j: @digitalstain @jennyowen @bfeshti

[yosifkit]

While it is not a big problem since we can just "Squash and Merge", we would appreciate if you could rebase plus force push your fork's branch rather than just pull/merge upstream master for a cleaner git commit history.

If we keep using `Squash and Merge" and your branch keeps adding "Merge branch 'master' into master", then the list of commits in each successive PR will grow indefinitely. One best practice is to always create a new branch based on the upstream target so that is it always up-to-date; the other is to ensure that a single re-used branch is rebased on upstream master to ensure that there is just a single (or couple) commits added for the PR.

[jennyowen]

Yeah I used to be able to edit the library file directly on github, then make a PR here and the PRs would have 1 neat commit. Then something happened (I forget what) and the git history on the neo4j library file got all tangled somehow. I reforked a month ago, but it was still broken afterwards.
Anyway, I've rebased our fork. In the future I'll make sure that each PR is one commit. Thanks @yosifkit !