Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the registry official image to point to a go1.4.3-built registry #1100

Merged
merged 1 commit into from
Oct 5, 2015

Conversation

RichardScothern
Copy link

Signed-off-by: Richard Scothern richard.scothern@gmail.com

@aaronlehmann
Copy link
Contributor

LGTM

@yosifkit
Copy link
Member

yosifkit commented Oct 5, 2015

Changeset: distribution/distribution-library-image@0258654...d5f65e0

LGTM, Build test of #1100; 23c1444 (registry):

$ url="https://raw.githubusercontent.com/docker-library/official-images/23c1444804196ce04e83799d88406ec7cfd7c0b4/library/registry"
$ bashbrew build "$url"
Fetching registry (git://github.com/docker/distribution-library-image) ...
Processing registry:latest ...
Processing registry:0.8.1 ...
Processing registry:0.9.1 ...
Processing registry:2 ...
Processing registry:2.1 ...
Processing registry:2.1.1 ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing registry:latest
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing registry:0.8.1
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...passed
testing registry:2
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...configuration error: open echo: no such file or directory
usage: /bin/registry <config>
  -test.bench="": regular expression to select benchmarks to run
  -test.benchmem=false: print memory allocations for benchmarks
  -test.benchtime=1s: approximate run time for each benchmark
  -test.blockprofile="": write a goroutine blocking profile to the named file after execution
  -test.blockprofilerate=1: if >= 0, calls runtime.SetBlockProfileRate()
  -test.coverprofile="": write a coverage profile to the named file after execution
  -test.cpu="": comma-separated list of number of CPUs to use for each test
  -test.cpuprofile="": write a cpu profile to the named file during execution
  -test.memprofile="": write a memory profile to the named file after execution
  -test.memprofilerate=0: if >=0, sets runtime.MemProfileRate
  -test.outputdir="": directory in which to write profiles
  -test.parallel=1: maximum test parallelism
  -test.run="": regular expression to select tests and examples to run
  -test.short=false: run smaller test suite to save time
  -test.timeout=0: if positive, sets an aggregate time limit for all tests
  -test.v=false: verbose: print additional output
  -version=false: show the version and exit
failed

There is at least one failure in the above build log.

@tianon
Copy link
Member

tianon commented Oct 5, 2015

LGTM

(#643 (comment) for context on that test failure)

tianon added a commit that referenced this pull request Oct 5, 2015
Update the registry official image to point to a go1.4.3-built registry
@tianon tianon merged commit 97fb1cf into docker-library:master Oct 5, 2015
@RichardScothern RichardScothern deleted the registry-go-1.4.3 branch November 11, 2016 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants