maven: switch openjdk latest to 17 #10981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
reviewed
Sep 29, 2021
library/maven
Outdated
| @@ -41,7 +41,7 @@ Architectures: amd64, arm64v8 | |||
| GitCommit: 0a7b1ef030687a5d95ce3e7567a4c279ab87dc81 | |||
| Directory: openjdk-11-slim | |||
|
|
|||
| Tags: 3.8.2-openjdk-16, 3.8.2, 3.8.2-openjdk, 3.8-openjdk-16, 3.8, 3.8-openjdk, 3-openjdk-16, 3, latest, 3-openjdk, openjdk | |||
| Tags: 3.8.2-openjdk-16, 3.8.2, 3.8-openjdk-16, 3.8, 3-openjdk-16, 3, latest | |||
There was a problem hiding this comment.
Did you also want 3.8.2, 3.8, 3, and latest to move to JDK 17?
There was a problem hiding this comment.
Is that a change that you are working on? It looks like I can add commits if you'd like me to just move them down.
There was a problem hiding this comment.
sorry I was reading it on the phone and didn't catch the issue, it should be fixed now
Diff for fc95949:diff --git a/_bashbrew-cat b/_bashbrew-cat
index 771e7d4..920d330 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -110,7 +110,7 @@ Architectures: amd64, arm64v8
GitCommit: 0a7b1ef030687a5d95ce3e7567a4c279ab87dc81
Directory: openjdk-11-slim
-Tags: 3.8.2-openjdk-16, 3.8.2, 3.8.2-openjdk, 3.8-openjdk-16, 3.8, 3.8-openjdk, 3-openjdk-16, 3, latest, 3-openjdk, openjdk
+Tags: 3.8.2-openjdk-16, 3.8-openjdk-16, 3-openjdk-16
Architectures: amd64, arm64v8
GitCommit: 0a7b1ef030687a5d95ce3e7567a4c279ab87dc81
Directory: openjdk-16
@@ -120,7 +120,7 @@ Architectures: amd64, arm64v8
GitCommit: 0a7b1ef030687a5d95ce3e7567a4c279ab87dc81
Directory: openjdk-16-slim
-Tags: 3.8.2-openjdk-17, 3.8-openjdk-17, 3-openjdk-17
+Tags: 3.8.2-openjdk-17, 3.8.2, 3.8.2-openjdk, 3.8-openjdk-17, 3.8, 3.8-openjdk, 3-openjdk-17, 3, latest, 3-openjdk, openjdk
Architectures: amd64, arm64v8
GitCommit: 0a7b1ef030687a5d95ce3e7567a4c279ab87dc81
Directory: openjdk-17
diff --git a/maven_openjdk/Dockerfile b/maven_3-openjdk-16/Dockerfile
similarity index 100%
copy from maven_openjdk/Dockerfile
copy to maven_3-openjdk-16/Dockerfile
diff --git a/maven_3-openjdk-17/mvn-entrypoint.sh b/maven_3-openjdk-16/mvn-entrypoint.sh
similarity index 100%
rename from maven_3-openjdk-17/mvn-entrypoint.sh
rename to maven_3-openjdk-16/mvn-entrypoint.sh
diff --git a/maven_3-openjdk-17/settings-docker.xml b/maven_3-openjdk-16/settings-docker.xml
similarity index 100%
rename from maven_3-openjdk-17/settings-docker.xml
rename to maven_3-openjdk-16/settings-docker.xml
diff --git a/maven_3-openjdk-17/Dockerfile b/maven_3-openjdk-17/Dockerfile
deleted file mode 100644
index 84383b4..0000000
diff --git a/maven_openjdk/Dockerfile b/maven_openjdk/Dockerfile
index a558957..84383b4 100644
--- a/maven_openjdk/Dockerfile
+++ b/maven_openjdk/Dockerfile
@@ -1,4 +1,4 @@
-FROM openjdk:16-jdk-oraclelinux8
+FROM openjdk:17-jdk-oraclelinux8
ARG MAVEN_VERSION=3.8.2
ARG USER_HOME_DIR="/root"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.