Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse-mosquitto: Fix issue with libwebsockets http2 support. #10628

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

ralight
Copy link
Contributor

@ralight ralight commented Jul 28, 2021

Disable http2 support in the compiled libwebsockets, it causes problems in some situations.

@github-actions
Copy link

Diff for 8663b19:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index a0ce141..4c47b5a 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,7 +1,7 @@
 Maintainers: Roger Light <roger@atchoo.org> (@ralight)
 Architectures: amd64, arm32v6, arm64v8, i386, ppc64le, s390x
 GitRepo: https://github.com/eclipse/mosquitto.git
-GitCommit: 5217863b8b210f22df81c6b95d1eb89ed4af9b50
+GitCommit: 17bbca22fb5dc57bfdc83ac60be67e34208825fd
 
 Tags: 1.5.11, 1.5
 Directory: docker/1.5
diff --git a/eclipse-mosquitto_1.5/Dockerfile b/eclipse-mosquitto_1.5/Dockerfile
index 612bd2c..b64fa49 100644
--- a/eclipse-mosquitto_1.5/Dockerfile
+++ b/eclipse-mosquitto_1.5/Dockerfile
@@ -30,6 +30,7 @@ RUN set -x && \
         -DLWS_WITHOUT_CLIENT=ON \
         -DLWS_WITHOUT_EXTENSIONS=ON \
         -DLWS_WITHOUT_TESTAPPS=ON \
+        -DLWS_WITH_HTTP2=OFF \
         -DLWS_WITH_SHARED=OFF \
         -DLWS_WITH_ZIP_FOPS=OFF \
         -DLWS_WITH_ZLIB=OFF && \
diff --git a/eclipse-mosquitto_1.6-openssl/Dockerfile b/eclipse-mosquitto_1.6-openssl/Dockerfile
index ff6b729..070e3a0 100644
--- a/eclipse-mosquitto_1.6-openssl/Dockerfile
+++ b/eclipse-mosquitto_1.6-openssl/Dockerfile
@@ -33,6 +33,7 @@ RUN set -x && \
         -DLWS_WITHOUT_EXTENSIONS=ON \
         -DLWS_WITHOUT_TESTAPPS=ON \
         -DLWS_WITH_EXTERNAL_POLL=ON \
+        -DLWS_WITH_HTTP2=OFF \
         -DLWS_WITH_SHARED=OFF \
         -DLWS_WITH_ZIP_FOPS=OFF \
         -DLWS_WITH_ZLIB=OFF && \
diff --git a/eclipse-mosquitto_1.6/Dockerfile b/eclipse-mosquitto_1.6/Dockerfile
index 46231c8..58ecda9 100644
--- a/eclipse-mosquitto_1.6/Dockerfile
+++ b/eclipse-mosquitto_1.6/Dockerfile
@@ -33,6 +33,7 @@ RUN set -x && \
         -DLWS_WITHOUT_EXTENSIONS=ON \
         -DLWS_WITHOUT_TESTAPPS=ON \
         -DLWS_WITH_EXTERNAL_POLL=ON \
+        -DLWS_WITH_HTTP2=OFF \
         -DLWS_WITH_SHARED=OFF \
         -DLWS_WITH_ZIP_FOPS=OFF \
         -DLWS_WITH_ZLIB=OFF && \
diff --git a/eclipse-mosquitto_latest/Dockerfile b/eclipse-mosquitto_latest/Dockerfile
index f08e6df..0a08be3 100644
--- a/eclipse-mosquitto_latest/Dockerfile
+++ b/eclipse-mosquitto_latest/Dockerfile
@@ -35,6 +35,7 @@ RUN set -x && \
         -DLWS_WITHOUT_EXTENSIONS=ON \
         -DLWS_WITHOUT_TESTAPPS=ON \
         -DLWS_WITH_EXTERNAL_POLL=ON \
+        -DLWS_WITH_HTTP2=OFF \
         -DLWS_WITH_SHARED=OFF \
         -DLWS_WITH_ZIP_FOPS=OFF \
         -DLWS_WITH_ZLIB=OFF && \
diff --git a/eclipse-mosquitto_openssl/Dockerfile b/eclipse-mosquitto_openssl/Dockerfile
index 841878b..8d33536 100644
--- a/eclipse-mosquitto_openssl/Dockerfile
+++ b/eclipse-mosquitto_openssl/Dockerfile
@@ -35,6 +35,7 @@ RUN set -x && \
         -DLWS_WITHOUT_EXTENSIONS=ON \
         -DLWS_WITHOUT_TESTAPPS=ON \
         -DLWS_WITH_EXTERNAL_POLL=ON \
+        -DLWS_WITH_HTTP2=OFF \
         -DLWS_WITH_SHARED=OFF \
         -DLWS_WITH_ZIP_FOPS=OFF \
         -DLWS_WITH_ZLIB=OFF && \

@yosifkit yosifkit merged commit d101ca5 into docker-library:master Jul 28, 2021
@mike-sandstrom
Copy link

Thank you for this as I have been having trouble connecting WSS on Firefox due to firefox initializing the connections with http2. I am still relatively inexperienced with github. So you changed the build of libwebsockets when installing mosquitto or is this just for the docker image of mosquitto?

@ralight
Copy link
Contributor Author

ralight commented Aug 5, 2021

@mike-sandstrom this is just for the docker image. How do you install mosquitto? Depending on the package there might be not a lot I can do.

@mike-sandstrom
Copy link

sudo apt-get. I can install it however makes it work though. I believe you mentioned that building mosquitto with cmake and turning off libwebsockets http2 is how to accomplish this, but I also saw you were planning on moving mosquitto away from libwebsockets. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants