-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch busybox over to co-maintainership #1058
Conversation
Build test of #1058; 6c5ea7b ( $ url="https://raw.githubusercontent.com/docker-library/official-images/6c5ea7b84c35f58818be3cb9f46e76d2f009df69/library/busybox"
$ bashbrew build "$url"
Cloning busybox (git://github.com/docker-library/busybox) ...
Processing busybox:ubuntu-1.21.0 ...
Processing busybox:ubuntu-1.21 ...
Processing busybox:ubuntu-1 ...
Processing busybox:ubuntu ...
Processing busybox:1.23.2 ...
Processing busybox:1.23 ...
Processing busybox:1 ...
Processing busybox:latest ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing busybox:ubuntu-1.21.0
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...passed
testing busybox:1.23.2
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...warning: garbage password detected for 'mail': 'x'
warning: garbage password detected for 'www-data': 'x'
warning: garbage password detected for 'sys': 'x'
passed
'override-cmd' [4/4]...passed |
@jpetazzo do you think we should switch the |
Maybe get this out first and then consider that separately. |
Ah, 1.22 is always better than 1.21, but it's not 1.23... I wouldn't mind dropping the ubuntu builder altogether if it makes maintenance easier. (In the beginning, I had two incentives to keep it around: it was an alternative to buildroot; and it was faster... But I don't know if those criteria should still be a concern!) |
Heh, the tarballs for it build fast enough that I'm not too worried about it for now. I'm fairly sure it's built against glibc too, so IMO it's still worth keeping around for a while longer (especially since the burden of it is low). Let's look at moving it to the Wily version in a later PR though. 👍 |
ubuntu-14.04: git://github.com/jpetazzo/docker-busybox@ca435164f45c40d761fad9ef9b5a76a6ba0d5f1a | ||
ubuntu-1.21.0: git://github.com/docker-library/busybox@9018eeb5d4be894da7fa94d21346d37dbd8ee847 ubuntu | ||
ubuntu-1.21: git://github.com/docker-library/busybox@9018eeb5d4be894da7fa94d21346d37dbd8ee847 ubuntu | ||
ubuntu-1: git://github.com/docker-library/busybox@9018eeb5d4be894da7fa94d21346d37dbd8ee847 ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be swapped to be version-ubuntu
, since that is the version of the software and not the version of Ubuntu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, update it with a new version built directly from upstream's sources (instead of relying on buildroot to update their embedded copy of busybox).
Build test of #1058; 77200a0 ( $ url="https://raw.githubusercontent.com/docker-library/official-images/77200a03e1e7af7c7a79f015db7cc77d4eb4cd03/library/busybox"
$ bashbrew build "$url"
Fetching busybox (git://github.com/docker-library/busybox) ...
Processing busybox:1.21.0-ubuntu ...
Processing busybox:1.21-ubuntu ...
Processing busybox:1-ubuntu ...
Processing busybox:ubuntu ...
Processing busybox:1.23.2 ...
Processing busybox:1.23 ...
Processing busybox:1 ...
Processing busybox:latest ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing busybox:1.21.0-ubuntu
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...passed
testing busybox:1.23.2
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...warning: garbage password detected for 'mail': 'x'
warning: garbage password detected for 'www-data': 'x'
warning: garbage password detected for 'sys': 'x'
passed
'override-cmd' [4/4]...passed |
LGTM |
Switch busybox over to co-maintainership
Also, update it with a new version built directly from upstream's sources (instead of relying on buildroot to update their embedded copy of busybox).
cc @jpetazzo