Update websphere-liberty:beta to September release

[davidcurrie]

No description provided.

[yosifkit]

Changeset: WASdev/ci.docker@c424138...65818b1

LGTM, Build test of #1022; 08e8a0f (websphere-liberty):

$ url="https://raw.githubusercontent.com/docker-library/official-images/08e8a0fb6560d52bf18ea99257d01758f7a6cba9/library/websphere-liberty"
$ bashbrew build "$url"
Fetching websphere-liberty (git://github.com/WASdev/ci.docker) ...
Processing websphere-liberty:kernel ...
Processing websphere-liberty:8.5.5.6-kernel ...
Processing websphere-liberty:common ...
Processing websphere-liberty:8.5.5.6-common ...
Processing websphere-liberty:webProfile6 ...
Processing websphere-liberty:8.5.5.6-webProfile6 ...
Processing websphere-liberty:webProfile7 ...
Processing websphere-liberty:8.5.5.6-webProfile7 ...
Processing websphere-liberty:javaee7 ...
Processing websphere-liberty:8.5.5.6-javaee7 ...
Processing websphere-liberty:8.5.5.6 ...
Processing websphere-liberty:8.5.5 ...
Processing websphere-liberty:latest ...
Processing websphere-liberty:beta ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing websphere-liberty:kernel
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...failed
testing websphere-liberty:common
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...failed
testing websphere-liberty:webProfile6
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...failed
testing websphere-liberty:webProfile7
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...failed
testing websphere-liberty:javaee7
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...failed
testing websphere-liberty:beta
    'utc' [1/4]...passed
    'cve-2014--shellshock' [2/4]...passed
    'no-hard-coded-passwords' [3/4]...passed
    'override-cmd' [4/4]...failed

There is at least one failure in the above build log.

ie, looks like our tests need some improvements.

[davidcurrie]

Hmm - will have to give that one some thought. You can override the command but the entry point still takes you through the script that does the license check i.e. you'd need to specify "-e LICENSE=accept" (which I appreciate you're not going to do!). That's not something that's changed since the original image though...

[yosifkit]

Yeah, that is what I saw. We have the test to help us on the goal of Consistency in official images. Does it make sense that they should accept the license even if they are just dropping into a bash shell? Seems reasonable to me, but I am not sure of the terms of the license.

[davidcurrie]

Well, the license acceptance replaces a check that would normally take place on download of Liberty so it may be that you should still accept it even if all your going to do is run bash because you would still get access to the installed files. I'll need to check with the legal beagles. I've opened WASdev/ci.docker#18 to track this.

[yosifkit]

@davidcurrie, Sounds good 👍

/cc @tianon Since this image has been this way from its beginning, we should get this merged and watch WASdev/ci.docker#18 to see what the outcome is.

[tianon]

LGTM