ADD step copies local node_modules to the container

[Guuz]

Hello,

As I have reported here:
GoogleCloudPlatform/nodejs-docker#22
and here:
dockerfile/nodejs-runtime#2

the local node_modules dir is copied over the correct one in the container. I'm thinking this might only be a problem when the .dockerignore file is not supported. This is the case on Google Managed VM's.
Could someone verifie it works as intended so we know it's only a problem for Managed VM's?

Thanks!

[yosifkit]

This should be solvable with .dockerignore. Is Google running a version of Docker that does not support dockerignore? It was added in 1.1.0. We ought to document what should be in the .dockerignore for onbuild images.

[tianon]

".dockerignore" is currently client-side, but that might change in a
future version to be both (it's been discussed briefly on a GH issue)

[Guuz]

Yes, the dockerignore is currently not supported. So with it this will work correctly? The user still needs to add this file and include the node_modules folder. There is a chance that they will miss this. Or is it in the docs?

Thanks for verifying!

[yosifkit]

We need to update the docs with a recommend .dockerignore. Made a issue to track: (docker-library/docs#79)

[proppy]

@Guuz just a note that the upcoming version of Managed VMs will comes with a more recent docker-py and hopefully support .dockerignore.

[Guuz]

@proppy thanks! Looking forward to that! :)

[pikeas]

It seems that the docs are missing the note about .dockerignore?

[yosifkit]

Closing old issue, (should be reported on https://github.com/nodejs/docker-node if you still have issues).