Skip to content

Move Launchpad references to my temp GitHub for now #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 16, 2024

In the future, we'll hopefully get busybox converted over to oci-import so that this will no longer be necessary and we can delete this whole file instead (in favor of a busybox file instead).

Fixes #25

In the future, we'll hopefully get `busybox` converted over to `oci-import` so that this will no longer be necessary and we can delete this whole file instead (in favor of a `busybox` file instead).
@tianon tianon requested a review from yosifkit as a code owner February 16, 2024 21:39
@tianon
Copy link
Member Author

tianon commented Feb 16, 2024

Unfortunately, this does mean that we're no longer verifying that our oci-import jobs do not accidentally hit our "missing .git suffix" error, but I don't think that tiny benefit is worth keeping this actively up-to-date with the latest Ubuntu releases.

error("\(.) does not end in '.git' so build will fail to recognize it as a Git URL")

Copy link

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yosifkit yosifkit merged commit 2523842 into docker-library:main Feb 16, 2024
@yosifkit yosifkit deleted the lunchpad branch February 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launchpad does not allow fetching arbitrary commits, which now breaks our tests here
3 participants