Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GO386 to "softfloat" in 1.16+ #355

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Update GO386 to "softfloat" in 1.16+ #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update GO386 to "softfloat" in 1.16+ 
See https://tip.golang.org/doc/go1.16#386.

It appears Alpine's definition of "x86" roughly matches Debian's definition of "i386" (ie, no sse2): https://gitlab.alpinelinux.org/alpine/aports/-/blob/39606c42c09836d93d2dac5469713b5f1d637682/community/go/APKBUILD#L74

Debian references (for posterity):

- https://www.debian.org/releases/stable/i386/ch02s01.en.html#idm276
- https://packages.debian.org/sid/sse2-support
- https://wiki.debian.org/ArchitectureSpecificsMemo#Architecture_baselines
  • Loading branch information
@tianon
tianon committed Jan 20, 2021
commit e069ef401a3eee2d16b5ad4dce939eaa02ae1bd1
2 changes: 1 addition & 1 deletion 1.16-rc/alpine3.12/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion 1.16-rc/alpine3.13/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Dockerfile-alpine.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ RUN set -eux; \
case "$apkArch" in \
armhf) export GOARM='6' ;; \
armv7) export GOARM='7' ;; \
x86) export GO386='387' ;; \
x86) export GO386='{{ if env.version == "1.14" or env.version == "1.15" then "387" else "softfloat" end }}' ;; \
esac; \
\
# https://github.com/golang/go/issues/38536#issuecomment-616897960
Expand Down