Add Austin to the official "Maintainers:" block #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
commented
Nov 28, 2022
generate-stackbrew-library.sh
Outdated
| @@ -57,7 +57,8 @@ cat <<-EOH | |||
| # this file is generated via https://github.com/docker-library/ghost/blob/$(fileCommit "$self")/$self | |||
|
|
|||
| Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon), | |||
| Joseph Ferguson <yosifkit@gmail.com> (@yosifkit) | |||
| Joseph Ferguson <yosifkit@gmail.com> (@yosifkit), | |||
| Austin Burdine (@acburdine) | |||
There was a problem hiding this comment.
Also happy to include the email address from your commits here, if you're OK with that, but didn't want to include it presumptuously since it's not publicly listed on your GitHub profile. 👍
There was a problem hiding this comment.
(It would also be totally appropriate for us to list you first instead of last, but I don't want to push you too hard! 😄)
There was a problem hiding this comment.
haha this is fine 😄 - feel free to add austin@acburdine.me as the email
acburdine
approved these changes
Nov 29, 2022
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 30, 2022
Changes: - docker-library/ghost@5387e32: Merge pull request docker-library/ghost#354 from infosiftr/acburdine - docker-library/ghost@ded8361: Add Austin to the official "Maintainers:" block - docker-library/ghost@5c614b2: Update to 5.24.2, ghost-cli 1.23.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@acburdine any objection to being "officially" listed here? (no hard feelings either way, but I figured a pull request was an effective way to ask! 😄)
The practical end result of this is that you'll get a "CC" on all the official-images update PRs and you'll get an @-reference any time there's a change that affects the
ghostimage in other ways (see docker-library/official-images#13577 (comment) for a recent example that didn't affectghostbut shows you the kind of thing that we use this for).