-
Notifications
You must be signed in to change notification settings - Fork 72
Refactor to mirror upstream "support tracks" (and add the still-upstream-supported 4.9 series back) #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam-supported 4.9 series back)
commit 8c7687860cdd4ef9227c249ca4587984e2636a55
Author: Tianon Gravi <admwiggin@gmail.com>
Date: Fri Sep 16 13:48:23 2016 -0700
Refactor to mirror upstream "support tracks" (and add the still-upstream-supported 4.9 series back)
diff --git a/.travis.yml b/.travis.yml
index 20a8995..d3208fb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,8 +2,9 @@ language: bash
services: docker
env:
- - VERSION=6.1
- - VERSION=5.3
+ - VERSION=6
+ - VERSION=5
+ - VERSION=4.9
install:
- git clone https://github.com/docker-library/official-images.git ~/official-images
diff --git a/5.3/Dockerfile b/4.9/Dockerfile
similarity index 96%
copy from 5.3/Dockerfile
copy to 4.9/Dockerfile
index 46068c0..474c452 100644
--- a/5.3/Dockerfile
+++ b/4.9/Dockerfile
@@ -13,9 +13,9 @@ RUN set -xe \
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
done
-# Last Modified: 2015-12-04
-ENV GCC_VERSION 5.3.0
-# Docker EOL: 2016-12-04
+# Last Modified: 2016-08-03
+ENV GCC_VERSION 4.9.4
+# Docker EOL: 2017-08-03
# "download_prerequisites" pulls down a bunch of tarballs and extracts them,
# but then leaves the tarballs themselves lying around
diff --git a/6.1/Dockerfile b/5/Dockerfile
similarity index 96%
rename from 6.1/Dockerfile
rename to 5/Dockerfile
index e2169b2..bb1e247 100644
--- a/6.1/Dockerfile
+++ b/5/Dockerfile
@@ -13,9 +13,9 @@ RUN set -xe \
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
done
-# Last Modified: 2016-04-27
-ENV GCC_VERSION 6.1.0
-# Docker EOL: 2017-04-27
+# Last Modified: 2016-06-03
+ENV GCC_VERSION 5.4.0
+# Docker EOL: 2017-06-03
# "download_prerequisites" pulls down a bunch of tarballs and extracts them,
# but then leaves the tarballs themselves lying around
diff --git a/5.3/Dockerfile b/6/Dockerfile
similarity index 96%
rename from 5.3/Dockerfile
rename to 6/Dockerfile
index 46068c0..59ef5e9 100644
--- a/5.3/Dockerfile
+++ b/6/Dockerfile
@@ -13,9 +13,9 @@ RUN set -xe \
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
done
-# Last Modified: 2015-12-04
-ENV GCC_VERSION 5.3.0
-# Docker EOL: 2016-12-04
+# Last Modified: 2016-08-22
+ENV GCC_VERSION 6.2.0
+# Docker EOL: 2017-08-22
# "download_prerequisites" pulls down a bunch of tarballs and extracts them,
# but then leaves the tarballs themselves lying around
diff --git a/generate-stackbrew-library.sh b/generate-stackbrew-library.sh
index 1c67832..77d405b 100755
--- a/generate-stackbrew-library.sh
+++ b/generate-stackbrew-library.sh
@@ -3,8 +3,7 @@ set -e
declare -A aliases=(
[4.9]='4'
- [5.3]='5'
- [6.1]='6 latest'
+ [6]='latest'
)
self="$(basename "$BASH_SOURCE")"
@@ -56,12 +55,16 @@ for version in "${versions[@]}"; do
dockerfile="$(git show "$commit":"$version/Dockerfile")"
fullVersion="$(echo "$dockerfile" | awk '$1 == "ENV" && $2 == "GCC_VERSION" { print $3; exit }')"
- versionAliases=(
- $fullVersion
+ versionAliases=()
+ while [ "$fullVersion" != "$version" -a "${fullVersion%[.-]*}" != "$fullVersion" ]; do
+ versionAliases+=( $fullVersion )
+ fullVersion="${fullVersion%[.-]*}"
+ done
+ versionAliases+=(
$version
${aliases[$version]:-}
)
-
+
echo
echo "$dockerfile" | grep -m1 '^# Last Modified: '
cat <<-EOE |
$ ./update.sh
+ sed -ri '
s/^(ENV GCC_VERSION) .*/\1 4.9.4/;
s/^(# Last Modified:) .*/\1 2016-08-03/;
s/^(# Docker EOL:) .*/\1 2017-08-03/;
' 4.9/Dockerfile
+ sed -ri '
s/^(ENV GCC_VERSION) .*/\1 5.4.0/;
s/^(# Last Modified:) .*/\1 2016-06-03/;
s/^(# Docker EOL:) .*/\1 2017-06-03/;
' 5/Dockerfile
+ sed -ri '
s/^(ENV GCC_VERSION) .*/\1 6.2.0/;
s/^(# Last Modified:) .*/\1 2016-08-22/;
s/^(# Docker EOL:) .*/\1 2017-08-22/;
' 6/Dockerfile $ ./generate-stackbrew-library.sh
# this file is generated via https://github.com/docker-library/gcc/blob/8c7687860cdd4ef9227c249ca4587984e2636a55/generate-stackbrew-library.sh
Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon),
Joseph Ferguson <yosifkit@gmail.com> (@yosifkit)
GitRepo: https://github.com/docker-library/gcc.git
# Last Modified: 2016-08-03
Tags: 4.9.4, 4.9, 4
GitCommit: 8c7687860cdd4ef9227c249ca4587984e2636a55
Directory: 4.9
# Docker EOL: 2017-08-03
# Last Modified: 2016-06-03
Tags: 5.4.0, 5.4, 5
GitCommit: 8c7687860cdd4ef9227c249ca4587984e2636a55
Directory: 5
# Docker EOL: 2017-06-03
# Last Modified: 2016-08-22
Tags: 6.2.0, 6.2, 6, latest
GitCommit: 8c7687860cdd4ef9227c249ca4587984e2636a55
Directory: 6
# Docker EOL: 2017-08-22 |
$ diff -u <(bashbrew cat gcc) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63 2016-09-16 13:54:10.869152257 -0700
+++ /dev/fd/62 2016-09-16 13:54:10.869152257 -0700
@@ -1,10 +1,14 @@
Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon), Joseph Ferguson <yosifkit@gmail.com> (@yosifkit)
GitRepo: https://github.com/docker-library/gcc.git
-Tags: 5.3.0, 5.3, 5
-GitCommit: df055b1ba29bd666470f4735f2a7bab9acffd0b3
-Directory: 5.3
+Tags: 4.9.4, 4.9, 4
+GitCommit: 8c7687860cdd4ef9227c249ca4587984e2636a55
+Directory: 4.9
-Tags: 6.1.0, 6.1, 6, latest
-GitCommit: d9c8446748f7d69626f2e9425376a6672fff09af
-Directory: 6.1
+Tags: 5.4.0, 5.4, 5
+GitCommit: 8c7687860cdd4ef9227c249ca4587984e2636a55
+Directory: 5
+
+Tags: 6.2.0, 6.2, 6, latest
+GitCommit: 8c7687860cdd4ef9227c249ca4587984e2636a55
+Directory: 6 |
cc @yosifkit |
yosifkit
approved these changes
Sep 16, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎈
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Sep 19, 2016
- `gcc`: explicitly support 4.9 (4.9.4), 5 (5.4.0), and 6 (6.2.0) tracks as upstream does (docker-library/gcc#29) - `kibana`: remove 4.0 (EOL) - `tomcat`: 7.0.72 - `wordpress`: fix escaping issues, especially for values starting with `-` (docker-library/wordpress#172)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://gcc.gnu.org/:
Note that the 5 and 6 series only get a minor bump, no patch bumps.