Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Semeru Runtimes docker documentation. #2017

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Updating the Semeru Runtimes docker documentation. #2017

merged 4 commits into from
Oct 21, 2021

Conversation

narkedi
Copy link
Contributor

@narkedi narkedi commented Aug 25, 2021

IBM Semeru Runtimes is responsible for delivering the official Docker Images with OpenJDK + Eclipse OpenJ9

@@ -0,0 +1,38 @@
## Overview

The files in this repository are used to built the images that contain IBM Semeru Runtime Open Edition OpenJDK binaries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used to built

*build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adam, updated it accordingly.

@@ -0,0 +1,37 @@
## Overview

The files in this repository are used to build the images that contain IBM Semeru Runtime Open Edition OpenJDK binaries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the generated README will link to the Dockerfiles used for building, this statement is incorrect since the files here are just the documentation that will appear on the Docker Hub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianon @yosifkit Updated the statement accordingly. Thanks !!

@tianon tianon merged commit 7700d81 into docker-library:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants