Skip to content

caddy: Updating docs for builder image changes - #1802

Merged
yosifkit merged 1 commit into
docker-library:masterfrom
hairyhenderson:caddy-update-docs-for-builder-changes
Sep 25, 2020
Merged

yosifkit merged 1 commit into
docker-library:masterfrom
hairyhenderson:caddy-update-docs-for-builder-changes

Conversation

@hairyhenderson

Copy link
Copy Markdown
Contributor

Changes relevant to docker-library/official-images#8735

Many thanks to @francislavoie for writing this 😉

Signed-off-by: Dave Henderson dhenderson@gmail.com

Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@hairyhenderson
hairyhenderson force-pushed the caddy-update-docs-for-builder-changes branch from 71f4d46 to 3829475 Compare September 25, 2020 00:32
@yosifkit
yosifkit merged commit c93a74d into docker-library:master Sep 25, 2020
@hairyhenderson
hairyhenderson deleted the caddy-update-docs-for-builder-changes branch September 26, 2020 00:10
Comment thread caddy/content.md

```Dockerfile
FROM %%IMAGE%%:2.0.0-builder AS builder
FROM %%IMAGE%%:<version>-builder AS builder

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yosifkit I hope you don't mind me asking like this on a merged PR.

Is there any way to dynamically replace this <version> with a placeholder? I dug through the scripts in this repo and I didn't find any relevant placeholders.

Ideally, I'd like a %%LATEST_VERSION%% placeholder that would basically be the version number that the latest tag shares.

I've already gotten a question from a user recently who is new to Docker asking "do I need to replace <version>?" so I think this should be improved.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, that's a somewhat complicated problem for us to solve generally, especially since in many cases using the "most specific" versioned tag isn't actually what we recommend users should use (PHP for example - most users should use X.Y not X.Y.Z so they continue to get patch updates and because that's the level at which compatibility is supposed to be kept between versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants