This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Do not fail cgroups setup if parent cgroup does not exist. #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed -- exec_test.go:297: [8] System error: mountpoint for devices not found |
| } else { | ||
| return err | ||
| } | ||
| return err |
There was a problem hiding this comment.
Why this change only in cpuset?
There was a problem hiding this comment.
The rest of the cgroup setups use data.path() and cpuset does something different. This change makes sure it stays in sync.
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
|
Fixed the cause for the test failure. PTAL. |
|
LGTM |
vmarmol
added a commit
that referenced
this pull request
Mar 16, 2015
Do not fail cgroups setup if parent cgroup does not exist.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now if the parent cgroup path is absolute, we expect the cgroups to exist. If it is not absolute, everything works as expected.