This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
nsenter: fix the -Wunused-variable warning #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change 699429e that allows the constructor attribute to not be optimized out on gccgo has resulted in a warning when compiling on the golang compiler. ``` ./nsenter.go: In function ‘_cgo_51505a0edd5d_Cfunc_init’: ./nsenter.go:40:49: warning: unused variable ‘a’ [-Wunused-variable] ``` the generated code produced an unused struct like: ``` void _cgo_d6cfae95ae01_Cfunc_init (void *v) { struct { char unused; } __attribute__ ((__packed__, __gcc_struct__)) * a = v; init (); } ``` Truly the "fix" would be upstream in cgo. If it knows it is producing an unused struct, then it should also include __attribute__ ((unused)) Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
ping @crosbymichael |
|
LGTM, thanks! I was seeing this recently. |
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Mar 10, 2015
nsenter: fix the -Wunused-variable warning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change 699429e that allows the
constructor attribute to not be optimized out on gccgo has resulted in a
warning when compiling on the golang compiler.
the generated code produced an unused struct like:
Truly the "fix" would be upstream in cgo. If it knows it is producing an
unused struct, then it should also include attribute ((unused))
Signed-off-by: Vincent Batts vbatts@hashbangbash.com