Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Add init path support to allow full control of init binary #404

Merged
merged 1 commit into from
Feb 25, 2015

Conversation

crosbymichael
Copy link
Contributor

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@LK4D4
Copy link
Contributor

LK4D4 commented Feb 25, 2015

Ah, I think you should use this function in libcontainer.New instead of setting InitArgs: []string{os.Args[0], "init"} directly.

@crosbymichael crosbymichael added this to the v2.0 milestone Feb 25, 2015
@vmarmol
Copy link
Contributor

vmarmol commented Feb 25, 2015

LGTM

vmarmol added a commit that referenced this pull request Feb 25, 2015
Add init path support to allow full control of init binary
@vmarmol vmarmol merged commit c96cde4 into docker-archive:master Feb 25, 2015
@crosbymichael crosbymichael deleted the init-path branch February 25, 2015 02:55
@LK4D4
Copy link
Contributor

LK4D4 commented Feb 25, 2015

I am still vote to have default value or make initArgs argument of New, because just New now creates unusable factory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants