This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] fix panic on empty dockerfile#199
Merged
andrewhsu merged 4 commits intodocker-archive:18.09from Jun 18, 2019
Merged
Conversation
Member
Author
|
ping @tonistiigi @LinuxMercedes ptal |
|
The failures looks unrelated: |
Member
Author
Ah, yes, I forgot the fix for that isn't merged yet; the fix for that is included in #198 😓 |
|
Ah! Looks good otherwise! 👍 |
b3b89f2 to
ea4aef0
Compare
Member
Author
|
rebased, now that #198 was merged |
|
Failures so far look flaky:
|
|
Oh, that janky failure is related. You'd need to include moby#38524 or backport docker/docker-py#2216 to whatever version of docker-py is included in this release. |
Member
Author
|
Oh, good catch thanks! opened a separate PR for that one #202 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit c0c05af) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…branch) - moby/buildkit#952 [18.09 backport] Have parser error on dockerfiles without instructions - backport of moby/buildkit#771 Have parser error on dockerfiles without instructions Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Wrap parse errors in errdefs.InvalidParameters - Include dockerfile in error names Signed-off-by: Natasha Jarus <linuxmercedes@gmail.com> (cherry picked from commit 64466b0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Natasha Jarus <linuxmercedes@gmail.com> (cherry picked from commit 18c7e8b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ea4aef0 to
cd084b2
Compare
Member
Author
|
rebased on top of #202 to get both changes in here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.