Skip to content
This repository was archived by the owner on Sep 12, 2018. It is now read-only.

Conversation

@eyz
Copy link
Contributor

@eyz eyz commented Mar 7, 2015

I found that I was unable to pull a tagged image from the master golang_impl due to the Docker pull sending "library/" as a prefix to the repoName in the HTTP GET. Since the repoName unexpectedly included "library/", GetRepositoryTags was returning an empty JSON object, and the image could not be located. This resolves the problem by allowing the portion after "library/" to be passed to the existing handler as it expects. My client and server API versions at the time of the failure (and resultant fix) were as follows -

Client version: 1.3.2
Client API version: 1.15
Go version (client): go1.3.3
Git commit (client): 39fa2fa
OS/Arch (client): linux/amd64
Server version: 1.3.2
Server API version: 1.15
Go version (server): go1.3.3
Git commit (server): 39fa2fa

I found that I was unable to pull a tagged image, and this resolves the problem. My version was as follows -

Client version: 1.3.2
Client API version: 1.15
Go version (client): go1.3.3
Git commit (client): 39fa2fa
OS/Arch (client): linux/amd64
Server version: 1.3.2
Server API version: 1.15
Go version (server): go1.3.3
Git commit (server): 39fa2fa
@dmp42
Copy link
Contributor

dmp42 commented Mar 8, 2015

The registry v1 golang implementation is entirely unsupported, and no effort goes into it.
For the sake of it, I'm merging this PR, but I would rather suggest you start looking into the next-generation registry over there: https://github.com/docker/distribution

dmp42 added a commit that referenced this pull request Mar 8, 2015
Support GET /v1/repositories/library/(.*?)/tags
@dmp42 dmp42 merged commit 593a6c2 into docker-archive:master Mar 8, 2015
@eyz eyz deleted the fix-for-get-repositories-library branch March 8, 2015 00:26
@eyz
Copy link
Contributor Author

eyz commented Mar 8, 2015

Thanks for the merge. We use CentOS and RHEL 7, and only Docker 1.3.2 is in EPEL at the moment; we try to use official packages as much as possible. I see Docker 1.5 is required for the new Go-based registry, and I'm looking forward to it. Single binary deployments are great. Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants