Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[17.06] Fix api server null pointer def on inspect/ls null ipam-driver networks #179

Merged

Conversation

thaJeztah
Copy link
Member

cherry-picked from moby/moby@beebfc0 (moby/moby#34395)

applied cleanly, no merge conflicts

  • When a network is created with the null ipam driver, docker api server
    thread will deference a nil pointer on docker network ls and on
    docker network inspect <nw>. This because buildIpamResource()
    assumes a gateway address is always present, which is not correct.

- When a network is created with the null ipam driver, docker api server
  thread will deference a nil pointer on `docker network ls` and on
  `docker network inspect <nw>`. This because buildIpamResource()
  assumes a gateway address is always present, which is not correct.

Signed-off-by: Alessandro Boch <aboch@tetrationanalytics.com>
(cherry picked from commit beebfc0)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu added this to the 17.06.1 milestone Aug 8, 2017
@andrewhsu andrewhsu merged commit c1e16c7 into docker-archive:17.06 Aug 8, 2017
@thaJeztah thaJeztah deleted the 17.06-backport-fix_api_server_null branch August 8, 2017 08:13
docker-jenkins pushed a commit that referenced this pull request Sep 4, 2018
Update new systemd unit file with changes from upstream
Upstream-commit: 5ef11d1
Component: packaging
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Feb 3, 2020
…ix_api_server_null

[17.06] Fix api server null pointer def on inspect/ls null ipam-driver networks
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
Update new systemd unit file with changes from upstream
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants