This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Host and Bridge network support in docker stack deploy #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be attached to special networks such as host and bridge. This fix brings in the required changes to make sure the stack file accepts these networks as well. Signed-off-by: Madhu Venugopal <madhu@docker.com> (cherry picked from commit 123f0bfd9894be11cb2da401dad513fd7373d41c)
Signed-off-by: Daniel Nephin <dnephin@docker.com> (cherry picked from commit 341703d21e88c55d3489404f9b4fbdcb1e97f98a)
Signed-off-by: Daniel Nephin <dnephin@docker.com> (cherry picked from commit d5b505ee8ceda32511359cff674472e349ea3a28)
23 tasks
|
Seeing error when running |
|
Its a flaky test : moby/moby#33337 and resolved via moby/moby#33307. Should we cherry-pick moby/moby#33307 ? |
|
LGTM all other integration and cli tests are green |
andrewhsu
added a commit
that referenced
this pull request
Jun 15, 2017
update rpm changelog Upstream-commit: c79e2ca Component: packaging
|
@thaJeztah @mavenugo Do we need doc changes? I am looking at https://docs.docker.com/compose/swarm/ and https://docs.docker.com/compose/networking/ for reference on how to setup local or bridge network for a service. EDIT: Maybe the note here needs to be updated https://docs.docker.com/compose/compose-file/#network_mode |
|
@marcusmartins can you check if the changes are already in https://github.com/docker/docker.github.io/tree/vnext-compose (which is the branch for the upcoming release), otherwise open an issue in the docs repository (or perhaps create a PR 😇 ) |
docker-jenkins
pushed a commit
that referenced
this pull request
Jul 10, 2018
[18.06] Improve scalability of the Linux load balancing Upstream-commit: c863835e99fb5ff4c121066d061e988fffd6c31a Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
Host and Bridge network support in docker stack deploy
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
update rpm changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking from docker/cli#132