This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Fix all the things #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c786ed.
- Go 1.8 --> 1.9 - Cuberite 630 --> 905 (MC 1.12) - Debian CA Certs oneliner
BROTHERG
approved these changes
Dec 15, 2017
thaJeztah
reviewed
Dec 15, 2017
| ARG DOCKER_VERSION=17.04.0-ce | ||
| RUN wget -qO- https://get.docker.com/builds/Linux/x86_64/docker-${DOCKER_VERSION}.tgz | \ | ||
| ARG DOCKER_VERSION=17.09.0-ce | ||
| RUN wget -qO- https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz | \ |
There was a problem hiding this comment.
You could even skip this entire build-stage; the COPY --from syntax also allows copying from an image. The following would pulls the official docker:17.09 image, and copy the CLI binary from that;
COPY --from=docker:17.09 /usr/local/bin/docker /bin|
|
||
| const ( | ||
| downloadURL = "https://get.docker.com/builds/Linux/x86_64/docker-" | ||
| downloadURL = "https://download.docker.com/linux/static/stable/x86_64/docker-" |
There was a problem hiding this comment.
Also wondering if the whole version-compare in GetDockerBinary() should still be there; versions older than Docker-CE 17.09 have reached EOL, so perhaps it should be simplified to remove that code.
tjhorner
approved these changes
Mar 22, 2018
|
Would also love to see this PR merged, and confirm it resolves issues running Dockercraft on MacOS as well. |
|
LGTM. Thanks for the contribution @lolPants |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker Image
Until this gets merged into the main repo, my changes will be available on my own docker account.
docker pull lolpants/dockercraftChanges
I've made a few changes and bugfixes, have a read.
Download URL
The Docker download URL changed causing the Go server to fail on download.
This updates for the new URL and also adds root CA certs for the Debian intermediary container to allow the new download to succeed.
Web Admin
This was added but I reverted it due to potential security risks. Might revisit it at some point.
Authentication
By default the Cuberite server doesn't care if you're logged in. This can be a problem if you want to use a whitelist. I've turned that on. (Also makes player skins work)
Dependencies
Both Cuberite and Go were out of date. They're now on the latest versions at time of writing. They've both been tested and work. This means you can now login to Dockercraft from Minecraft versions
1.8to1.12.New Containers
Starting a new container will cause all other containers within Dockercraft to disappear. They're still running, but they don't exist in the world until they're updated. Using a hack this forces all containers to re-render when this happens and fixes that issue.