Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Bump docker/cli 19.03 with rollback_config interpolation fix#572

Merged
silvin-lubecki merged 1 commit intodocker-archive-public:masterfrom
silvin-lubecki:bump-docker-cli
Jul 12, 2019
Merged

Bump docker/cli 19.03 with rollback_config interpolation fix#572
silvin-lubecki merged 1 commit intodocker-archive-public:masterfrom
silvin-lubecki:bump-docker-cli

Conversation

@silvin-lubecki
Copy link
Contributor

- What I did
It bumps docker/cli with this fix: docker/cli#1973
Fix #559

- How to verify it
docker app rendering the following file does not fail:

$ cat test.dockerapp
# This section contains your application metadata.
# Version of the application
version: 0.1.0
# Name of the application
name: hello-world
# A short description of the application
description: "Hello, World!"
# List of application maintainers with name and email for each
maintainers:
  - name: user
    email: "user@email.com"
---
# This section contains the Compose file that describes your application services.
version: "3.7"
services:
  hello:
    image: hashicorp/http-echo
    command: ["-text", "${text}"]
    ports:
      - ${port}:5678
    deploy:
      rollback_config:
        parallelism: "${deploy.rollback-config.parallelism}"
        max_failure_ratio: "${deploy.rollback-config.max_failure_ratio}"
---
# This section contains the default values for your application parameters.
port: 8080
text: Hello, World!
deploy:
  rollback-config:
    parallelism: 3
    max_failure_ratio: 0.9

$ docker app render test.dockerapp
...

- Description for the changelog

  • Bump docker/cli 19.03 with rollback_config interpolation fix

- A picture of a cute animal (not mandatory but encouraged)

image

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #572 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   70.67%   70.67%           
=======================================
  Files          55       55           
  Lines        3223     3223           
=======================================
  Hits         2278     2278           
  Misses        646      646           
  Partials      299      299

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de4c3f...3e7bcad. Read the comment docs.

Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 93a66d6 into docker-archive-public:master Jul 12, 2019
@silvin-lubecki silvin-lubecki deleted the bump-docker-cli branch July 12, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subkeys render error - parallelism and max_failure_ratio

4 participants