Skip to content
This repository was archived by the owner on Nov 9, 2020. It is now read-only.

Remove deprecation warnings #Take3 #124

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/test/java/xyz/docbleach/api/BleachTestBase.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package xyz.docbleach.api;

import static org.mockito.Matchers.any;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.util.function.Predicate;
import org.apache.poi.hpsf.ClassID;
import org.apache.poi.hpsf.ClassIDPredefined;
import org.apache.poi.poifs.filesystem.DirectoryEntry;
import org.apache.poi.poifs.filesystem.DocumentEntry;
import org.apache.poi.poifs.filesystem.DocumentInputStream;
Expand Down Expand Up @@ -52,7 +52,7 @@ public void sanitize(InputStream inputStream, OutputStream outputStream, BleachS
// @TODO: Filter based on Storage Class ID - see issue #23
sanitize(session, fsIn, fs);

if (ClassID.EXCEL97.equals(fs.getRoot().getStorageClsid())) {
if (ClassIDPredefined.EXCEL_V8.equals(fs.getRoot().getStorageClsid())) {
ExcelRecordCleaner.cleanupAndSaveExcel97(fs, outputStream);
} else {
fs.writeFilesystem(outputStream);
Expand Down Expand Up @@ -80,7 +80,7 @@ protected void sanitize(BleachSession session, DirectoryEntry rootIn, DirectoryE
.and(new ObjectRemover(session))
.and(new SummaryInformationSanitiser(session));

LOGGER.debug("Root ClassID: {}", rootIn.getStorageClsid());
LOGGER.debug("Root ClassIDPredefined: {}", rootIn.getStorageClsid());
// https://blogs.msdn.microsoft.com/heaths/2006/02/27/identifying-windows-installer-file-types/
rootOut.setStorageClsid(rootIn.getStorageClsid());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.eq;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.atLeastOnce;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ private void sanitizeEmbeddedFile(PDComplexFileSpecification fileSpec) {
LOGGER.trace("Embedded file found: {}", fileSpec.getFilename());

fileSpec.setEmbeddedFile(sanitizeEmbeddedFile(fileSpec.getEmbeddedFile()));
fileSpec.setEmbeddedFileDos(sanitizeEmbeddedFile(fileSpec.getEmbeddedFileDos()));
fileSpec.setEmbeddedFileMac(sanitizeEmbeddedFile(fileSpec.getEmbeddedFileMac()));
//fileSpec.setEmbeddedFileDos(sanitizeEmbeddedFile(fileSpec.getEmbeddedFileDos()));
//fileSpec.setEmbeddedFileMac(sanitizeEmbeddedFile(fileSpec.getEmbeddedFileMac()));
fileSpec.setEmbeddedFileUnicode(sanitizeEmbeddedFile(fileSpec.getEmbeddedFileUnicode()));
fileSpec.setEmbeddedFileUnix(sanitizeEmbeddedFile(fileSpec.getEmbeddedFileUnix()));
//fileSpec.setEmbeddedFileUnix(sanitizeEmbeddedFile(fileSpec.getEmbeddedFileUnix()));
}

private PDEmbeddedFile sanitizeEmbeddedFile(PDEmbeddedFile file) {
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@

<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
<version>1.10.19</version>
<artifactId>mockito-core</artifactId>
<version>4.0.0</version>
<scope>test</scope>
</dependency>

Expand Down