feat(agents): grant session-history tool to compaction-enabled agents#879
Merged
Merged
Conversation
Add `harnx_agent_session_history_read` to the `use_tools` of every bundled agent that has a `compaction_agent` configured. After a compaction these agents can now search their own pre-compaction session history (issue #819, tool added in #851) to recover any context dropped during summarization. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (37)
📝 WalkthroughWalkthroughA new changeset records patch bumps for ChangesSession History Tool Grant to Bundled Agents
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
harnx_agent_session_history_readto theuse_toolslist of every bundled agent that has acompaction_agentconfigured (36 agents acrossexample_config,packages/coding, andpackages/pantheon).Why
The session-history search tool (issue #819, implemented in #851) lets an agent grep its own pre-compaction session transcript to recover context that summarization may have dropped. But the tool is gated by
use_tools— it's only offered to an agent that lists it explicitly or uses a*wildcard (seeconfig/mod.rsand thesession_history_tool_declaration_is_gated_by_use_toolstest).None of the bundled compaction-enabled agents used a wildcard, so the tool the compaction flow points them at (
session_ops_split.rs) was never actually callable. This grants it to exactly the agents that undergo compaction.Scope
compaction_agent:field — i.e. agents that get compacted.role: compactionsummarizer agents andshared/prompt fragments are intentionally excluded; they don't need to search their own history.use_toolsentry in each file, matching each file's existing indentation.Verification
use_tools.cargo nextest -p harnx-runtimeagent/config/compaction-loading tests: 62 passed.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Chores