make sure main log file uses new naming scheme

[zluudg]

Summary by CodeRabbit

• Chores
  • Updated default configuration and log file paths to use the "dnstapir-" naming convention across POP and CLI components for consistent naming.

[coderabbitai]

Warning

Rate limit exceeded

@zluudg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1649e63 and 5c8a482.

📒 Files selected for processing (1)

• defaults.go (1 hunks)

Walkthrough

Updated configuration and default constants to rename file paths from the "tapir-" prefix to "dnstapir-" and corrected the dnstapir-pop component log path to match the component name.

Changes

Cohort / File(s)	Summary
Configuration path correction cmd/cfgfiles/dnstapir-pop.yaml	Updated log file path from /var/log/dnstapir/tapir-pop.log to /var/log/dnstapir/dnstapir-pop.log.
Default config file constants defaults.go	Updated exported constants: DefaultPopCfgFile from "/etc/dnstapir/tapir-pop.yaml" to "/etc/dnstapir/dnstapir-pop.yaml", and DefaultTapirCliCfgFile from "/etc/dnstapir/tapir-cli.yaml" to "/etc/dnstapir/dnstapir-cli.yaml".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Files/areas to check closely:

• defaults.go — ensure no other code depends on the exact old filenames and update any docs or scripts.
• cmd/cfgfiles/dnstapir-pop.yaml — verify log rotation/permissions still correct for the new filename.

Possibly related PRs

• use 'dnstapir' prefix for files and folders #47 — Renames configuration/filename prefixes from tapir- to dnstapir-, directly related.
• Added default paths for main pop and cli conf files #32 — Earlier change that introduced the tapir-*.yaml defaults now being renamed; directly related.

Suggested reviewers

• johanix
• eest

Poem

🐰 A path once labeled tapir, now true,
dnstapir hops in with a fresher view.
Logs find their home with a tidy new name,
The rabbit applauds consistency's claim! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "make sure main log file uses new naming scheme" accurately refers to a real and tangible aspect of the changeset. The pull request does indeed update file paths to follow a new naming scheme, changing from naming patterns like "tapir-pop" and "tapir-cli" to "dnstapir-pop" and "dnstapir-cli" across both the yaml configuration file and the exported constants in defaults.go. However, the title focuses narrowly on the "main log file" and doesn't encompass the full scope of changes, which also includes updates to configuration file path constants (DefaultPopCfgFile and DefaultTapirCliCfgFile). The title thus represents a partially related summary—it captures a legitimate aspect of the changes but not the complete picture.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

cmd/cfgfiles/dnstapir-pop.yaml (1)

5-5: Consider naming consistency across all log files.

The main log file now uses dnstapir-pop.log, but other log files in the same config use the pop-* pattern (line 5: pop-dnsengine.log, line 41: pop-mqtt.log). If the naming scheme should be uniform across all log files, consider updating lines 5 and 41 to dnstapir-pop-dnsengine.log and dnstapir-pop-mqtt.log respectively.

Please verify if the mixed naming pattern is intentional (distinguishing the main log from sub-component logs) or if all log files should follow the same naming convention.

Also applies to: 41-41, 64-64

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e072a3 and 6149766.

📒 Files selected for processing (1)

• cmd/cfgfiles/dnstapir-pop.yaml (1 hunks)

🔇 Additional comments (1)

cmd/cfgfiles/dnstapir-pop.yaml (1)

64-64: Main log file naming updated successfully.

The change aligns with the PR objective to update the main log file to use the new naming scheme.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6149766 and 1649e63.

📒 Files selected for processing (1)

• defaults.go (1 hunks)

🔇 Additional comments (1)

defaults.go (1)

13-13: CLI configuration path updated correctly.

The path change from "tapir-cli.yaml" to "dnstapir-cli.yaml" is confirmed correct. All references in the codebase (cmd/nodeman.go) are already aligned with the new path name, so no breaking changes detected.