Remove hardcoded label faces, let gfm-mode fontify headers#97
Merged
Conversation
Remove pi-coding-agent-user-label (dodger blue), pi-coding-agent-assistant-label (sea green), pi-coding-agent-compaction-label (medium purple), and pi-coding-agent-separator faces. Drop the face parameter from pi-coding-agent--make-separator — gfm-mode fontifies setext H1 headings via markdown-header-face-1, which every theme customizes. Replace hardcoded hex backgrounds in tool block faces: - tool-block-pending: inherit secondary-selection - tool-block-success: inherit diff-added - tool-block-error: inherit diff-removed All colors now come from the active theme.
dnouri
force-pushed
the
remove-hardcoded-label-faces
branch
from
67034cc to
f95a07a
Compare
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
Remove pi-coding-agent-user-label (dodger blue), pi-coding-agent-assistant-label (sea green), pi-coding-agent-compaction-label (medium purple), and pi-coding-agent-separator faces. Drop the face parameter from pi-coding-agent--make-separator — gfm-mode fontifies setext H1 headings via markdown-header-face-1, which every theme customizes. Replace hardcoded hex backgrounds in tool block faces: - tool-block-pending: inherit secondary-selection - tool-block-success: inherit diff-added - tool-block-error: inherit diff-removed All colors now come from the active theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All custom faces used hardcoded colors that clash with custom themes. Now everything inherits from standard theme-aware faces.
Removed faces (headers now fontified by gfm-mode as setext H1):
pi-coding-agent-separator— underline hidden bymarkdown-hide-markuppi-coding-agent-user-label— wasdodger bluepi-coding-agent-assistant-label— wassea greenpi-coding-agent-compaction-label— wasmedium purpleSimplified tool block faces (replaced hardcoded hex backgrounds):
tool-block-pending:#2a2a35/#f0f0f5→inherit secondary-selectiontool-block-success:#2a352a/#f0f5f0→inherit diff-addedtool-block-error:#352a2a/#f5f0f0→inherit diff-removed