fix: Crash in transient submenus and stale dependency version#94
Merged
fix: Crash in transient submenus and stale dependency version#94
Conversation
Three issues fixed: 1. Submenu crash with empty key: fallback suffix used key "" which causes (lookup-key keymap "") to return the keymap itself. Fix: return nil from :setup-children. 2. Edit columns crash: returned [level class args children] vectors but :setup-children expects [class args children] (transient 0.7+). Fix: drop the level element. 3. Bump transient minimum from 0.3.7 to 0.7.0 (Emacs 30 builtin). Older transient used a different internal vector format that is incompatible with :setup-children returns. The deps target now installs MELPA transient for Emacs 28 and 29.
dnouri
force-pushed
the
fix/transient-empty-key-and-version-check
branch
from
4d4a623 to
a8424b4
Compare
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
Three issues fixed: 1. Submenu crash with empty key: fallback suffix used key "" which causes (lookup-key keymap "") to return the keymap itself. Fix: return nil from :setup-children. 2. Edit columns crash: returned [level class args children] vectors but :setup-children expects [class args children] (transient 0.7+). Fix: drop the level element. 3. Bump transient minimum from 0.3.7 to 0.7.0 (Emacs 30 builtin). Older transient used a different internal vector format that is incompatible with :setup-children returns. The deps target now installs MELPA transient for Emacs 28 and 29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three crashes fixed:
"", causing(lookup-key keymap "")to return the keymap itself →wrong-type-argument: command:setup-childrenreturned 4-element vectors[level class args children]instead of expected[class args children]→wrong-type-argument: listp, transient-columnPackage-Requiresdeclared transient0.3.7but code usestransient-parse-suffixes(introduced in0.4.0). Added load-time warning.Tests added for all three submenu types (empty and populated states).