fix: Capture chat buffer in new-session callback#36
Merged
Conversation
The async callback in pi-coding-agent-new-session relied on current buffer context to find the chat buffer, but async callbacks run in arbitrary buffer contexts. This caused pi-coding-agent--clear-chat-buffer to silently do nothing when the callback was executed in a non-pi buffer. Fix: Capture chat-buf before the async call and use with-current-buffer in the callback, consistent with other commands like pi-coding-agent-cycle-thinking. Also add buffer-live-p check to handle case where buffer is killed while waiting for RPC response.
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
The async callback in pi-coding-agent-new-session relied on current buffer context to find the chat buffer, but async callbacks run in arbitrary buffer contexts. This caused pi-coding-agent--clear-chat-buffer to silently do nothing when the callback was executed in a non-pi buffer. Fix: Capture chat-buf before the async call and use with-current-buffer in the callback, consistent with other commands like pi-coding-agent-cycle-thinking. Also add buffer-live-p check to handle case where buffer is killed while waiting for RPC response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async callback in pi-coding-agent-new-session relied on current buffer context to find the chat buffer, but async callbacks run in arbitrary buffer contexts.
This caused pi-coding-agent--clear-chat-buffer to silently do nothing when the callback was executed in a non-pi buffer.
Fix: Capture chat-buf before the async call and use with-current-buffer in the callback, consistent with other commands like pi-coding-agent-cycle-thinking.
Also add buffer-live-p check to handle case where buffer is killed while waiting for RPC response.