Display thinking content with custom styling#2
Merged
Conversation
Owner
dnouri
commented
Dec 30, 2025
dnouri
commented
- Handle thinking_start, thinking_delta, thinking_end events
- Use ```thinking markdown fence which becomes #+begin_src thinking
- Add pi-thinking face (italic, comment color)
- Add font-lock to apply face to thinking block content
- Simple streaming approach: just insert markers at start/end, no replacement
- Handle thinking_start, thinking_delta, thinking_end events - Use ```thinking markdown fence which becomes #+begin_src thinking - Add pi-thinking face (italic, comment color) - Add font-lock to apply face to thinking block content - Simple streaming approach: just insert markers at start/end, no replacement
dnouri
added a commit
that referenced
this pull request
Jan 28, 2026
Uncle Bob review fixes: Issue #1 & #2: Extract pi-coding-agent--prepare-and-send - Single function handles display/tracking for all send paths - Used by pi-coding-agent-send, follow-up queue, and custom commands - Consistent behavior: slash commands never display locally Issue #3: Add edge case test - Test for when template expands to same text as command - Documents expected behavior (skip display if identical) Issue #4: Fix JSON boolean encoding - Use :json-false instead of :false for json-encode - :false encodes to string "false", :json-false encodes to boolean false - Updated extension UI confirm handler Issue #5: Improve test coverage - Add assertion verifying expanded content is displayed - Add test for different expanded content case
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
- Handle thinking_start, thinking_delta, thinking_end events - Use ```thinking markdown fence which becomes #+begin_src thinking - Add pi-thinking face (italic, comment color) - Add font-lock to apply face to thinking block content - Simple streaming approach: just insert markers at start/end, no replacement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.