Skip to content

Add local checkout to local load path#130

Merged
dnouri merged 1 commit intodnouri:masterfrom
jorgeavaldez:fix/tests/add-local-load-path-to-makefile
Feb 18, 2026
Merged

Add local checkout to local load path#130
dnouri merged 1 commit intodnouri:masterfrom
jorgeavaldez:fix/tests/add-local-load-path-to-makefile

Conversation

@jorgeavaldez
Copy link
Contributor

make test locally breaks with errors like this:

Test pi-coding-agent-test-toggle-no-session-errors backtrace:
  signal(ert-test-failed (((should-error (pi-coding-agent-toggle) :typ
  ert-fail(((should-error (pi-coding-agent-toggle) :type 'user-error)
  ert--should-error-handle-error(#f(lambda () [(form-description-5113
  (condition-case -condition- (unwind-protect (setq value-5111 (apply
  (let ((errorp5114 nil) (form-description-fn-5115 #'(lambda nil form-
  (let (form-description-5113) (let ((errorp5114 nil) (form-descriptio
  (let ((value-5111 'ert-form-evaluation-aborted-5112)) (let (form-des
  (let* ((fn-5109 #'pi-coding-agent-toggle) (args-5110 (condition-case
  (progn (fset 'project-current vnew) (let* ((fn-5109 #'pi-coding-agen
  (unwind-protect (progn (fset 'project-current vnew) (let* ((fn-5109
  (let* ((vnew #'(lambda (&rest _) nil)) (old (symbol-function 'projec
  (let ((default-directory "/tmp/pi-coding-agent-test-no-session/")) (
  #f(lambda () [t] (let ((default-directory "/tmp/pi-coding-agent-test
  #f(compiled-function () #<bytecode 0x126f4d144f1b0ccc>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x126f4d144f1b0ccc
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name pi-coding-agent-test-toggle-no-sessio
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "." "-L" "test" "--eval" "(setq load-prefer-new
  command-line()
  normal-top-level()
Test pi-coding-agent-test-toggle-no-session-errors condition:
    (ert-test-failed
     ((should-error (pi-coding-agent-toggle) :type 'user-error) :form
      (pi-coding-agent-toggle) :condition
      (void-function pi-coding-agent-toggle) :fail-reason
      "the error signaled did not have the expected type"))
   FAILED  479/564  pi-coding-agent-test-toggle-no-session-errors (0.000057 sec) at test/pi-coding-agent-test.el:111

the load path is picking up my local copy of the package at ~/.emacs.d/elpa/pi-coding-agent, NOT the local version.
this works in the github action because there's no melpa checkout.

with this change, the tests run locally regardless of the version my emacs is using.

@dnouri dnouri merged commit 7e0ee91 into dnouri:master Feb 18, 2026
7 checks passed
dnouri added a commit that referenced this pull request Feb 25, 2026
…th-to-makefile

Add local checkout to local load path
dnouri added a commit that referenced this pull request Feb 26, 2026
…th-to-makefile

Add local checkout to local load path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants