fix: Centralize PI_VERSION and fix nightly CI failures#108
Merged
Conversation
- test-gui.yml: 0.50.1 → 0.51.3 - test-integration.yml: 0.50.4 → 0.51.3 - nightly.yml: 0.50.1 → 0.51.3 in version matrix - README.org: update nightly description (0.48.0 → 0.51.3) - Remove dead get_commands skip guards (0.50.1 compat no longer needed) - Makefile: set load-prefer-newer to avoid stale .elc in make test
Workflows now extract PI_VERSION from Makefile instead of hardcoding it. Updating the pinned version only requires changing one line in the Makefile. Nightly simplified to test just two versions: pinned + latest. Removed pi-mono main branch builds (noise — latest covers forward compat).
The test called accept-process-output once for 1 second, which returns as soon as ANY output arrives. If residual output from the prompt phase was buffered, it returned immediately — before the set_session_name RPC response arrived. The file was then read before the write happened. Fix: poll for the RPC callback flag with a proper timeout loop, matching the pattern used by all other integration tests.
Was stuck at 0.1.0 while the main file had 1.2.6. Both files are part of the same package and should have matching versions.
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
* fix: Pin all CI workflows to minimum supported pi version (0.51.3) - test-gui.yml: 0.50.1 → 0.51.3 - test-integration.yml: 0.50.4 → 0.51.3 - nightly.yml: 0.50.1 → 0.51.3 in version matrix - README.org: update nightly description (0.48.0 → 0.51.3) - Remove dead get_commands skip guards (0.50.1 compat no longer needed) - Makefile: set load-prefer-newer to avoid stale .elc in make test * refactor: Centralize PI_VERSION — Makefile is single source of truth Workflows now extract PI_VERSION from Makefile instead of hardcoding it. Updating the pinned version only requires changing one line in the Makefile. Nightly simplified to test just two versions: pinned + latest. Removed pi-mono main branch builds (noise — latest covers forward compat). * fix: Session-name integration test race condition The test called accept-process-output once for 1 second, which returns as soon as ANY output arrives. If residual output from the prompt phase was buffered, it returned immediately — before the set_session_name RPC response arrived. The file was then read before the write happened. Fix: poll for the RPC callback flag with a proper timeout loop, matching the pattern used by all other integration tests. * fix: Sync pi-coding-agent-core.el version header to 1.2.6 Was stuck at 0.1.0 while the main file had 1.2.6. Both files are part of the same package and should have matching versions.
dnouri
added a commit
that referenced
this pull request
Feb 26, 2026
* fix: Pin all CI workflows to minimum supported pi version (0.51.3) - test-gui.yml: 0.50.1 → 0.51.3 - test-integration.yml: 0.50.4 → 0.51.3 - nightly.yml: 0.50.1 → 0.51.3 in version matrix - README.org: update nightly description (0.48.0 → 0.51.3) - Remove dead get_commands skip guards (0.50.1 compat no longer needed) - Makefile: set load-prefer-newer to avoid stale .elc in make test * refactor: Centralize PI_VERSION — Makefile is single source of truth Workflows now extract PI_VERSION from Makefile instead of hardcoding it. Updating the pinned version only requires changing one line in the Makefile. Nightly simplified to test just two versions: pinned + latest. Removed pi-mono main branch builds (noise — latest covers forward compat). * fix: Session-name integration test race condition The test called accept-process-output once for 1 second, which returns as soon as ANY output arrives. If residual output from the prompt phase was buffered, it returned immediately — before the set_session_name RPC response arrived. The file was then read before the write happened. Fix: poll for the RPC callback flag with a proper timeout loop, matching the pattern used by all other integration tests. * fix: Sync pi-coding-agent-core.el version header to 1.2.6 Was stuck at 0.1.0 while the main file had 1.2.6. Both files are part of the same package and should have matching versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefile is now the single source of truth for the pinned pi version.
Workflows extract it automatically — no more scattered version strings to keep in sync.
Changes
grep, eliminating 4 hardcoded version strings across workflow filesaccept-process-outputreturned early on buffered output before the RPC completed. Now uses a proper polling loopload-prefer-newerso tests always run against sourceTest Results
make check(compile + lint + tests) ✅