-
-
Notifications
You must be signed in to change notification settings - Fork 771
FIX: Change Default Template DNN Logo to Vector #6754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Change Default Template DNN Logo to Vector #6754
Conversation
|
@valadas Am I correct that only the "zipped" template resources are part of the Repo? |
|
It doesn't make a big difference, but I thought it might make sense to move the <?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
- width="155px" height="62px" viewBox="-42.52 77.519 155 62" enable-background="new -42.52 77.519 155 62" xml:space="preserve">
-<path fill="#FFFFFF" d="M43.598,115.273h-4.551v-9.107h4.551c2.516,0,4.559,2.04,4.559,4.553
+ width="155px" height="62px" viewBox="-42.52 77.519 155 62" enable-background="new -42.52 77.519 155 62" xml:space="preserve"
+ fill="#FFFFFF">
+<path d="M43.598,115.273h-4.551v-9.107h4.551c2.516,0,4.559,2.04,4.559,4.553
C48.157,113.234,46.114,115.273,43.598,115.273 M43.598,98.332H30.994v24.777h12.604c6.848,0,12.393-5.547,12.393-12.393
C55.99,103.88,50.446,98.332,43.598,98.332"/>
-<path fill="#FFFFFF" d="M83.959,110.603c-0.063-6.786-5.582-12.271-12.385-12.271H59.189v24.777h8.053v-16.725h4.332
+<path d="M83.959,110.603c-0.063-6.786-5.582-12.271-12.385-12.271H59.189v24.777h8.053v-16.725h4.332
c2.397,0,4.339,1.941,4.339,4.336v12.39h8.05v-12.507H83.959z"/>
-<path fill="#FFFFFF" d="M112.473,110.603c-0.064-6.786-5.578-12.271-12.379-12.271H87.701v24.777h8.055v-16.725h4.338
+<path d="M112.473,110.603c-0.064-6.786-5.578-12.271-12.379-12.271H87.701v24.777h8.055v-16.725h4.338
c2.395,0,4.336,1.941,4.336,4.336v12.39h8.051v-12.507H112.473z"/>
-<path fill="#FFFFFF" d="M-3.951,79.015c-2.551-0.689-5.236-1.061-8.004-1.061H-42.52v38.571h20.376V98.333h18.191L-3.951,79.015
+<path d="M-3.951,79.015c-2.551-0.689-5.236-1.061-8.004-1.061H-42.52v38.571h20.376V98.333h18.191L-3.951,79.015
L-3.951,79.015z M-1.766,79.697L-1.766,79.697v18.635h18.637C13.798,89.651,6.916,82.763-1.766,79.697 M17.549,100.519H-1.766v8.013
c-0.009,5.623-4.567,10.177-10.188,10.177h-8.004v20.375h8.004c16.88,0,30.562-13.683,30.562-30.564
C18.606,105.751,18.239,103.068,17.549,100.519 M-42.52,139.083h20.375v-20.377H-42.52V139.083z"/>
</svg> |
@bdukes That is a nice idea, but for this specific logo would we want people using it in "orange" as an example? |
|
Makes sense, we'll keep it as-is |
I don't understand what you mean here... |
|
Oh I see now what you mean. I think so. It would be nicer if we could have the resources sources and for the build process to size that up in a perfect world. But currently o think you are correct |
Yes that would be nice, but this works. :-) |
|
It no longer shows since we merged it, so we are good here... |
|
Wait, it does still show, hold on... |
I'll close this one pull develop locally and and do a new PR, OK @valadas ? |
…form into feature/6750-logo
valadas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine now, merging.
Summary
Added a true vector SVG Logo to the Default template Resources file.
Code:
fixes #6750