Remove missing license from DotNetNuke.Web.Deprecated nuget package configuration #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r2567-build-issues
valadas
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on development (v9.4.0) have been failing a few days. It appears (either or both) PRs #2567 #2730 played a part in this, along with our issues with github api rate limiting due to an a few issues with dependabot we weren't getting great build status' reported.
Either way, this should solve the error which is preventing devops from completing successfully. I don't believe we need to include this license with the nuget package. A quick scan of the PDF doesn't state it needs to be distributed as well. If we do decide we want this file included in the nuget package, we will need to add a rename step to change the file from .resources back to .pdf, or restore the pdf, or just package the .resources file.