Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure setting a render equal picture does not result in paint updates #656

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

dnfield
Copy link
Owner

@dnfield dnfield commented Jan 21, 2022

This is basically #655 with a test, and also bumping some changelog/pubspec stuff.

@coveralls
Copy link

coveralls commented Jan 21, 2022

Pull Request Test Coverage Report for Build 5886909158260736

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 52 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.4%) to 84.218%

Files with Coverage Reduction New Missed Lines %
lib/src/render_picture.dart 1 82.35%
lib/src/utilities/numbers.dart 1 88.89%
lib/src/picture_cache.dart 3 88.24%
lib/src/svg/parser_state.dart 3 94.61%
lib/src/picture_stream.dart 4 60.2%
lib/svg.dart 4 81.44%
lib/src/picture_provider.dart 10 51.79%
lib/src/vector_drawable.dart 26 86.74%
Totals Coverage Status
Change from base Build 5672608678019072: -2.4%
Covered Lines: 1745
Relevant Lines: 2072

💛 - Coveralls

@dnfield dnfield merged commit ce9dc0e into master Jan 21, 2022
@dnfield dnfield deleted the fix_equals branch January 21, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants